From patchwork Fri Sep 19 22:59:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anish Bhatt X-Patchwork-Id: 391444 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B28D6140161 for ; Sat, 20 Sep 2014 09:00:58 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932380AbaISXAa (ORCPT ); Fri, 19 Sep 2014 19:00:30 -0400 Received: from 99-65-72-228.uvs.sntcca.sbcglobal.net ([99.65.72.228]:22642 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932205AbaISXA3 convert rfc822-to-8bit (ORCPT ); Fri, 19 Sep 2014 19:00:29 -0400 Received: from nice.asicdesigners.com (nice.asicdesigners.com [10.192.160.7]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id s8JMxECH020861; Fri, 19 Sep 2014 15:59:14 -0700 Received: from NICE.asicdesigners.com ([fe80::51b2:ba95:9d72:babc]) by nice.asicdesigners.com ([fe80::51b2:ba95:9d72:babc%15]) with mapi id 14.02.0247.003; Fri, 19 Sep 2014 15:59:14 -0700 From: Anish Bhatt To: Randy Dunlap , "netdev@vger.kernel.org" , David Miller CC: LKML , James Bottomley Subject: RE: [PATCH] scsi: fix SCSI_BNX2X_FCOE dependencies and build errors Thread-Topic: [PATCH] scsi: fix SCSI_BNX2X_FCOE dependencies and build errors Thread-Index: AQHP1Fppssfx2r3GbUujvsveyIG5wJwJES7V Date: Fri, 19 Sep 2014 22:59:13 +0000 Message-ID: <525DB349B3FB5444AE057A887CB2A8D88EF6BE@nice.asicdesigners.com> References: <541CB055.6000504@infradead.org> In-Reply-To: <541CB055.6000504@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.192.163.152] MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Leaves only 1 warning still reproduceable : (LIBFCOE && TCM_QLA2XXX) selects LIBFC which has unmet direct dependencies (SCSI_LOWLEVEL && SCSI && SCSI_FC_ATTRS), so maybe that needs a fix too ? All the other fcoe/scsi menu entries behave as expected. Tested-by: Anish Bhatt --- linux-next-20140918.orig/drivers/scsi/bnx2fc/Kconfig +++ linux-next-20140918/drivers/scsi/bnx2fc/Kconfig @@ -1,7 +1,8 @@ config SCSI_BNX2X_FCOE tristate "QLogic NetXtreme II FCoE support" - depends on PCI + depends on PCI && NET depends on (IPV6 || IPV6=n) + depends on SCSI_FC_ATTRS select NETDEVICES select ETHERNET select NET_VENDOR_BROADCOM