From patchwork Thu Jan 15 10:11:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Jarosch X-Patchwork-Id: 429321 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 54C941401AF for ; Thu, 15 Jan 2015 21:11:24 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752426AbbAOKLR (ORCPT ); Thu, 15 Jan 2015 05:11:17 -0500 Received: from rs04.intra2net.com ([85.214.66.2]:59901 "EHLO rs04.intra2net.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751392AbbAOKLO (ORCPT ); Thu, 15 Jan 2015 05:11:14 -0500 Received: from intranator.m.i2n (unknown [172.16.1.99]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by rs04.intra2net.com (Postfix) with ESMTP id D7291220107; Thu, 15 Jan 2015 11:11:12 +0100 (CET) Received: from localhost (intranator.m.i2n [127.0.0.1]) by localhost (Postfix) with ESMTP id 8EA242AC5A; Thu, 15 Jan 2015 11:11:12 +0100 (CET) X-Virus-Scanned: by Intranator (www.intra2net.com) with AMaViS and F-Secure AntiVirus (fsavdb 2015-01-15_03) X-Spam-Status: X-Spam-Level: 0 Received: from storm.localnet (storm.m.i2n [172.16.1.2]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by intranator.m.i2n (Postfix) with ESMTPS id A4E4F2AC55; Thu, 15 Jan 2015 11:11:09 +0100 (CET) From: Thomas Jarosch To: Eric Dumazet Cc: 'Linux Netdev List' , Eric Dumazet , Jeff Kirsher , e1000-devel Subject: Re: [bisected regression] e1000e: "Detected Hardware Unit Hang" Date: Thu, 15 Jan 2015 11:11:09 +0100 Message-ID: <5229621.KczjbIR22Q@storm> Organization: Intra2net AG User-Agent: KMail/4.14.3 (Linux/3.17.8-200.fc20.x86_64; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1421256052.11734.22.camel@edumazet-glaptop2.roam.corp.google.com> References: <1719052.SGOfRAJhfQ@storm> <1421256052.11734.22.camel@edumazet-glaptop2.roam.corp.google.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wednesday, 14. January 2015 09:20:52 Eric Dumazet wrote: > I would try to use lower data per txd. I am not sure 24KB is really > supported. > > ( check commit d821a4c4d11ad160925dab2bb009b8444beff484 for details) > > diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c > b/drivers/net/ethernet/intel/e1000e/netdev.c index > e14fd85f64eb..8d973f7edfbd 100644 > --- a/drivers/net/ethernet/intel/e1000e/netdev.c > +++ b/drivers/net/ethernet/intel/e1000e/netdev.c > @@ -3897,7 +3897,7 @@ void e1000e_reset(struct e1000_adapter *adapter) > * limit of 24KB due to receive synchronization limitations. > */ > adapter->tx_fifo_limit = min_t(u32, ((er32(PBA) >> 16) << 10) - 96, > - 24 << 10); > + 8 << 10); > > /* Disable Adaptive Interrupt Moderation if 2 full packets cannot > * fit in receive buffer. Thanks for checking! I just tried that change on top of git f800c25 (git HEAD), same problem. Let's see what the Intel wizards come up with. What "works" is to decrease the page size in git HEAD, too: When I try a page size of 8192, it starts failing again. I'll now run a stress test with 4096 to see if the problem is really gone or just happens more rarely. Cheers, Thomas --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 85ab7d7..9f0ef97 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -2108,7 +2108,7 @@ static inline void __skb_queue_purge(struct sk_buff_head *list) kfree_skb(skb); } -#define NETDEV_FRAG_PAGE_MAX_ORDER get_order(32768) +#define NETDEV_FRAG_PAGE_MAX_ORDER get_order(4096) #define NETDEV_FRAG_PAGE_MAX_SIZE (PAGE_SIZE << NETDEV_FRAG_PAGE_MAX_ORDER) #define NETDEV_PAGECNT_MAX_BIAS NETDEV_FRAG_PAGE_MAX_SIZE