From patchwork Thu May 30 06:03:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Gang X-Patchwork-Id: 247458 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 94B5E2C0091 for ; Thu, 30 May 2013 16:05:24 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967556Ab3E3GEw (ORCPT ); Thu, 30 May 2013 02:04:52 -0400 Received: from intranet.asianux.com ([58.214.24.6]:45947 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967530Ab3E3GEl (ORCPT ); Thu, 30 May 2013 02:04:41 -0400 Received: by intranet.asianux.com (Postfix, from userid 103) id 6D5DF184028F; Thu, 30 May 2013 14:04:40 +0800 (CST) X-Spam-Score: -100.8 X-Spam-Checker-Version: SpamAssassin 3.1.9 (2007-02-13) on intranet.asianux.com X-Spam-Level: X-Spam-Status: No, score=-100.8 required=5.0 tests=AWL,BAYES_00, RATWARE_GECKO_BUILD,USER_IN_WHITELIST autolearn=no version=3.1.9 Received: from [10.1.0.143] (unknown [219.143.36.82]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by intranet.asianux.com (Postfix) with ESMTP id 0B8341840251; Thu, 30 May 2013 14:04:40 +0800 (CST) Message-ID: <51A6EBC5.7040601@asianux.com> Date: Thu, 30 May 2013 14:03:49 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: edumazet@google.com, Pravin Shelar , mgorman@suse.de CC: David Miller , Andrew Morton , "linux-kernel@vger.kernel.org" , netdev Subject: [PATCH] include/linux/skbuff.h: using '0xffff' instead of '~0U' Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Both 'transport_header' and 'mac_header' are u16, which are never equal to '~0U'. So need use '0xffff' instead of '~0U'. The related warning (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig) include/linux/skbuff.h:1587:2: warning: comparison is always true due to limited range of data type [-Wtype-limits] ... Signed-off-by: Chen Gang --- include/linux/skbuff.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 2e0ced1..03ba058 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -1581,7 +1581,7 @@ static inline void skb_set_inner_mac_header(struct sk_buff *skb, } static inline bool skb_transport_header_was_set(const struct sk_buff *skb) { - return skb->transport_header != ~0U; + return skb->transport_header != 0xffff; } static inline unsigned char *skb_transport_header(const struct sk_buff *skb) @@ -1624,7 +1624,7 @@ static inline unsigned char *skb_mac_header(const struct sk_buff *skb) static inline int skb_mac_header_was_set(const struct sk_buff *skb) { - return skb->mac_header != ~0U; + return skb->mac_header != 0xffff; } static inline void skb_reset_mac_header(struct sk_buff *skb)