From patchwork Mon Apr 22 10:24:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Gang X-Patchwork-Id: 238423 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id CA8B52C2510 for ; Mon, 22 Apr 2013 20:24:49 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754370Ab3DVKYq (ORCPT ); Mon, 22 Apr 2013 06:24:46 -0400 Received: from intranet.asianux.com ([58.214.24.6]:33271 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754354Ab3DVKYp (ORCPT ); Mon, 22 Apr 2013 06:24:45 -0400 Received: by intranet.asianux.com (Postfix, from userid 103) id A3E6B1840382; Mon, 22 Apr 2013 18:24:44 +0800 (CST) X-Spam-Score: -100.8 X-Spam-Checker-Version: SpamAssassin 3.1.9 (2007-02-13) on intranet.asianux.com X-Spam-Level: X-Spam-Status: No, score=-100.8 required=5.0 tests=AWL,BAYES_00, RATWARE_GECKO_BUILD,USER_IN_WHITELIST autolearn=no version=3.1.9 Received: from [10.1.0.143] (unknown [219.143.36.82]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by intranet.asianux.com (Postfix) with ESMTP id 4EE6D1840242; Mon, 22 Apr 2013 18:24:44 +0800 (CST) Message-ID: <51750FC0.8000603@asianux.com> Date: Mon, 22 Apr 2013 18:24:00 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: David Miller , "dhowells@redhat.com" , "Eric W. Biederman" , Rusty Russell , Serge Hallyn CC: netdev Subject: [PATCH] Net: rxrpc: signed and unsigned issue, need type cast for n_elem. Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org n_elem is unsigned int which never < 0. but it seems, we realy need check it whether < 0. so need a type cast for it. find it by EXTRA_CFLAGS=-W Signed-off-by: Chen Gang --- net/rxrpc/ar-key.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/rxrpc/ar-key.c b/net/rxrpc/ar-key.c index 7633a75..ba0b722 100644 --- a/net/rxrpc/ar-key.c +++ b/net/rxrpc/ar-key.c @@ -346,7 +346,7 @@ static int rxrpc_krb5_decode_tagged_array(struct krb5_tagged_data **_td, n_elem = ntohl(*xdr++); toklen -= 4; - if (n_elem < 0 || n_elem > max_n_elem) + if ((int)n_elem < 0 || n_elem > max_n_elem) return -EINVAL; *_n_elem = n_elem; if (n_elem > 0) {