From patchwork Tue Apr 2 01:37:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Gang X-Patchwork-Id: 232850 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B63312C0117 for ; Tue, 2 Apr 2013 12:38:32 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759720Ab3DBBi2 (ORCPT ); Mon, 1 Apr 2013 21:38:28 -0400 Received: from intranet.asianux.com ([58.214.24.6]:41399 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759704Ab3DBBi2 (ORCPT ); Mon, 1 Apr 2013 21:38:28 -0400 Received: by intranet.asianux.com (Postfix, from userid 103) id AC1DC1840236; Tue, 2 Apr 2013 09:38:26 +0800 (CST) X-Spam-Score: -100.8 X-Spam-Checker-Version: SpamAssassin 3.1.9 (2007-02-13) on intranet.asianux.com X-Spam-Level: X-Spam-Status: No, score=-100.8 required=5.0 tests=AWL,BAYES_00, RATWARE_GECKO_BUILD,USER_IN_WHITELIST autolearn=no version=3.1.9 Received: from [10.1.0.143] (unknown [219.143.36.82]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by intranet.asianux.com (Postfix) with ESMTP id 384D41840236; Tue, 2 Apr 2013 09:38:26 +0800 (CST) Message-ID: <515A3674.7090606@asianux.com> Date: Tue, 02 Apr 2013 09:37:56 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Sergei Shtylyov , isdn@linux-pingi.de, Jiri Slaby , 'Jiri Kosina' , tilman@imap.cc CC: David Miller , "netdev@vger.kernel.org >> netdev" Subject: [PATCH] ISDN:divert: beautify code: useless 'break', 'return (0)', additional comments. References: <5158E854.7060902@asianux.com> <515993E1.5010508@cogentembedded.com> In-Reply-To: <515993E1.5010508@cogentembedded.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org delete useless 'break' after 'return'. let 'return 0' instead of 'return (0)' also give a comment for 'break' to let readers notice it. Signed-off-by: Chen Gang Signed-off-by: Sergei Shtylyov --- drivers/isdn/divert/isdn_divert.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/isdn/divert/isdn_divert.c b/drivers/isdn/divert/isdn_divert.c index db432e6..50749a7 100644 --- a/drivers/isdn/divert/isdn_divert.c +++ b/drivers/isdn/divert/isdn_divert.c @@ -441,8 +441,7 @@ static int isdn_divert_icall(isdn_ctrl *ic) switch (dv->rule.action) { case DEFLECT_IGNORE: - return (0); - break; + return 0; case DEFLECT_ALERT: case DEFLECT_PROCEED: @@ -510,10 +509,9 @@ static int isdn_divert_icall(isdn_ctrl *ic) break; default: - return (0); /* ignore call */ - break; + return 0; /* ignore call */ } /* switch action */ - break; + break; /* will break the 'for' looping */ } /* scan_table */ if (cs) {