From patchwork Thu Feb 28 07:51:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Gang X-Patchwork-Id: 223790 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 33A6C2C008C for ; Thu, 28 Feb 2013 18:51:51 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752028Ab3B1Hvs (ORCPT ); Thu, 28 Feb 2013 02:51:48 -0500 Received: from intranet.asianux.com ([58.214.24.6]:33586 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751708Ab3B1Hvq (ORCPT ); Thu, 28 Feb 2013 02:51:46 -0500 Received: by intranet.asianux.com (Postfix, from userid 103) id A9A781840297; Thu, 28 Feb 2013 15:51:45 +0800 (CST) X-Spam-Score: -100.8 X-Spam-Checker-Version: SpamAssassin 3.1.9 (2007-02-13) on intranet.asianux.com X-Spam-Level: X-Spam-Status: No, score=-100.8 required=5.0 tests=AWL,BAYES_00, RATWARE_GECKO_BUILD,USER_IN_WHITELIST autolearn=no version=3.1.9 Received: from [10.1.0.143] (unknown [219.143.36.82]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by intranet.asianux.com (Postfix) with ESMTP id 6D0D01840247; Thu, 28 Feb 2013 15:51:45 +0800 (CST) Message-ID: <512F0C7F.1010304@asianux.com> Date: Thu, 28 Feb 2013 15:51:27 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: kaber@trash.net, David Miller CC: netdev Subject: [PATCH] net/8021q: beautify code, name_type is unsigned int, always >= 0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org args.u.name_type is unsigned int, which is always >= 0 Signed-off-by: Chen Gang --- net/8021q/vlan.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index a187144..0f5261a 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -571,8 +571,7 @@ static int vlan_ioctl_handler(struct net *net, void __user *arg) err = -EPERM; if (!ns_capable(net->user_ns, CAP_NET_ADMIN)) break; - if ((args.u.name_type >= 0) && - (args.u.name_type < VLAN_NAME_TYPE_HIGHEST)) { + if (args.u.name_type < VLAN_NAME_TYPE_HIGHEST) { struct vlan_net *vn; vn = net_generic(net, vlan_net_id);