diff mbox

ipv6: fix the bug when we do not have a socket context

Message ID 50ACB71C.4080101@gmail.com
State Rejected, archived
Delegated to: David Miller
Headers show

Commit Message

duanjiong Nov. 21, 2012, 11:12 a.m. UTC 
call the ip6_update_pmtu/ip6_redirect function to deal with
ICMPV6 Error Messages and Redirect Message, when we do not
have a socket context.

Signed-off-by: Duan Jiong <djduanjiong@gmail.com>
---
 net/ipv6/raw.c |   16 +++++++++++++++-
 1 files changed, 15 insertions(+), 1 deletions(-)

Comments

Eric Dumazet Nov. 21, 2012, 2:40 p.m. UTC | #1 
On Wed, 2012-11-21 at 19:12 +0800, Duan Jiong wrote:
> call the ip6_update_pmtu/ip6_redirect function to deal with
> ICMPV6 Error Messages and Redirect Message, when we do not
> have a socket context.
> 
> Signed-off-by: Duan Jiong <djduanjiong@gmail.com>
> ---

What is the exact problem you want to solve ?

What is the possible impact on the routing table size ?

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index d8e95c7..b10f478 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -354,7 +354,9 @@  void raw6_icmp_error(struct sk_buff *skb, int nexthdr,
 	const struct in6_addr *saddr, *daddr;
 	struct net *net;
 
+
 	hash = nexthdr & (RAW_HTABLE_SIZE - 1);
+	net = dev_net(skb->dev);
 
 	read_lock(&raw_v6_hashinfo.lock);
 	sk = sk_head(&raw_v6_hashinfo.ht[hash]);
@@ -363,7 +365,6 @@  void raw6_icmp_error(struct sk_buff *skb, int nexthdr,
 		const struct ipv6hdr *ip6h = (const struct ipv6hdr *)skb->data;
 		saddr = &ip6h->saddr;
 		daddr = &ip6h->daddr;
-		net = dev_net(skb->dev);
 
 		while ((sk = __raw_v6_lookup(net, sk, nexthdr, saddr, daddr,
 						IP6CB(skb)->iif))) {
@@ -371,6 +372,19 @@  void raw6_icmp_error(struct sk_buff *skb, int nexthdr,
 					inner_offset, info);
 			sk = sk_next(sk);
 		}
+	} else {
+		switch (type) {
+			case ICMPV6_PKT_TOOBIG:
+				ip6_update_pmtu(skb, net, info, 0, 0);
+				break;
+			
+			case NDISC_REDIRECT:
+				ip6_redirect(skb, net, 0, 0);
+				break;
+
+			default:
+				break;
+		}		
 	}
 	read_unlock(&raw_v6_hashinfo.lock);
 }