From patchwork Mon Nov 5 11:31:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Gang X-Patchwork-Id: 197194 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 232E82C0082 for ; Mon, 5 Nov 2012 22:30:30 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752642Ab2KELa1 (ORCPT ); Mon, 5 Nov 2012 06:30:27 -0500 Received: from intranet.asianux.com ([58.214.24.6]:32741 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751640Ab2KELa0 (ORCPT ); Mon, 5 Nov 2012 06:30:26 -0500 Received: by intranet.asianux.com (Postfix, from userid 103) id 09ACA1840336; Mon, 5 Nov 2012 19:30:25 +0800 (CST) X-Spam-Score: -100.8 X-Spam-Checker-Version: SpamAssassin 3.1.9 (2007-02-13) on intranet.asianux.com X-Spam-Level: X-Spam-Status: No, score=-100.8 required=5.0 tests=AWL,BAYES_00, RATWARE_GECKO_BUILD,USER_IN_WHITELIST autolearn=no version=3.1.9 Received: from [10.1.0.143] (unknown [219.143.36.82]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by intranet.asianux.com (Postfix) with ESMTP id A849D184020C; Mon, 5 Nov 2012 19:30:24 +0800 (CST) Message-ID: <5097A38F.2000003@asianux.com> Date: Mon, 05 Nov 2012 19:31:27 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: David Miller , kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net CC: netdev Subject: [PATCH] driver: net: ppp: change 8% to %s for seq_printf of pppoe_seq_show Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org the length of po->pppoe_pa.dev is 16 (IFNAMSIZ) in seq_printf, it is not suitable to use %8s for po->pppoe_pa.dev. so change it to %s, since each line has not been solid any more. Signed-off-by: Chen Gang --- drivers/net/ppp/pppoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) return 0; diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c index 20f31d0..7e89710 100644 --- a/drivers/net/ppp/pppoe.c +++ b/drivers/net/ppp/pppoe.c @@ -1009,7 +1009,7 @@ static int pppoe_seq_show(struct seq_file *seq, void *v) po = v; dev_name = po->pppoe_pa.dev; - seq_printf(seq, "%08X %pM %8s\n", + seq_printf(seq, "%08X %pM %s\n", po->pppoe_pa.sid, po->pppoe_pa.remote, dev_name); out: