From patchwork Fri Nov 2 16:01:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: solomon X-Patchwork-Id: 196586 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F20672C008C for ; Sat, 3 Nov 2012 03:03:24 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758773Ab2KBQBo (ORCPT ); Fri, 2 Nov 2012 12:01:44 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:58766 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758486Ab2KBQBl (ORCPT ); Fri, 2 Nov 2012 12:01:41 -0400 Received: by mail-pa0-f46.google.com with SMTP id hz1so2547906pad.19 for ; Fri, 02 Nov 2012 09:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=GtjQg/oA5MU4YBztx944vRA8zGdst0uTgYOfs9KEppA=; b=e7nP/wvRlS8YCsoG8qjVqB1MzekbP4FuWgZcLv+/QpY70mYvbBQNxRiBI1mQMW35DR uvYRRSoBHkg4Xa8Cg3ckaZE5B2dCGe3UkB9bPMasyH4CaPVB/jX7/DFHbF2tP/P7F2Df kFauLJQkRKr7/tAqxXS8GbZGnLVkZocsg8xqLmmcykgf8VSZcMy2GXsH50YcfYjWDB6E 1p6hPRIENTVhzuDE9/PZlPOU+AvYQs4XLpW8an3HqrhSXJ5HrM8+xxxO6KTU0g1Olbt6 j41ocj/u8+MhsGz2LR893k+MS38a9aAQNhkgBPiNOixHHIVo3Wf1Wg0sr6lFiHdnk9dv UC1w== Received: by 10.66.88.197 with SMTP id bi5mr6409310pab.58.1351872101694; Fri, 02 Nov 2012 09:01:41 -0700 (PDT) Received: from [172.30.10.98] ([121.14.96.125]) by mx.google.com with ESMTPS id ok3sm5951473pbb.11.2012.11.02.09.01.33 (version=SSLv3 cipher=OTHER); Fri, 02 Nov 2012 09:01:41 -0700 (PDT) Message-ID: <5093EE59.8010609@gmail.com> Date: Sat, 03 Nov 2012 00:01:29 +0800 From: Shan Wei User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: jesse@nicira.com, dev@openvswitch.org, NetDev , Kernel-Maillist , David Miller , cl@linux-foundation.org, Shan Wei Subject: [PATCH 4/9] net: openvswitch: use this_cpu_ptr per-cpu helper Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Shan Wei no change vs v1. Lots of drivers use this kind to read/write per-cpu variable. stats = this_cpu_ptr(dp->stats_percpu); u64_stats_update_begin(&stats->sync); stats->tx_packets++; u64_stats_update_begin(&stats->sync); Signed-off-by: Shan Wei --- net/openvswitch/datapath.c | 4 ++-- net/openvswitch/vport.c | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 4c4b62c..77d16a5 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -208,7 +208,7 @@ void ovs_dp_process_received_packet(struct vport *p, struct sk_buff *skb) int error; int key_len; - stats = per_cpu_ptr(dp->stats_percpu, smp_processor_id()); + stats = this_cpu_ptr(dp->stats_percpu); /* Extract flow from 'skb' into 'key'. */ error = ovs_flow_extract(skb, p->port_no, &key, &key_len); @@ -282,7 +282,7 @@ int ovs_dp_upcall(struct datapath *dp, struct sk_buff *skb, return 0; err: - stats = per_cpu_ptr(dp->stats_percpu, smp_processor_id()); + stats = this_cpu_ptr(dp->stats_percpu); u64_stats_update_begin(&stats->sync); stats->n_lost++; diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index 03779e8..70af0be 100644 --- a/net/openvswitch/vport.c +++ b/net/openvswitch/vport.c @@ -333,8 +333,7 @@ void ovs_vport_receive(struct vport *vport, struct sk_buff *skb) { struct vport_percpu_stats *stats; - stats = per_cpu_ptr(vport->percpu_stats, smp_processor_id()); - + stats = this_cpu_ptr(vport->percpu_stats); u64_stats_update_begin(&stats->sync); stats->rx_packets++; stats->rx_bytes += skb->len; @@ -359,7 +358,7 @@ int ovs_vport_send(struct vport *vport, struct sk_buff *skb) if (likely(sent)) { struct vport_percpu_stats *stats; - stats = per_cpu_ptr(vport->percpu_stats, smp_processor_id()); + stats = this_cpu_ptr(vport->percpu_stats); u64_stats_update_begin(&stats->sync); stats->tx_packets++;