| Message ID | 506889a6-4148-89f9-302e-4be069595bb4@web.de |
|---|---|
| State | Deferred |
| Delegated to: | David Miller |
| Headers | show |
| Series | net/phy/mdio-mscc-miim: Adjustments for mscc_miim_probe() | expand |
On Fri, Sep 20, 2019 at 09:02:40PM +0200, Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 20 Sep 2019 20:20:34 +0200 > > Simplify this function implementation by using a known wrapper function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
>> Simplify this function implementation by using a known wrapper function. … > Reviewed-by: Andrew Lunn <andrew@lunn.ch> Does this feedback indicate also an agreement for the detail if the mapping of internal phy registers would be a required operation? (Would such a resource allocation eventually be optional?) https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/phy/mdio-mscc-miim.c?id=f41def397161053eb0d3ed6861ef65985efbf293#n145 https://elixir.bootlin.com/linux/v5.3.1/source/drivers/net/phy/mdio-mscc-miim.c#L145 Regards, Markus
On 26/09/2019 17:29:02+0200, Markus Elfring wrote: > >> Simplify this function implementation by using a known wrapper function. > … > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > Does this feedback indicate also an agreement for the detail > if the mapping of internal phy registers would be a required operation? > (Would such a resource allocation eventually be optional?) It is optional.
>> Does this feedback indicate also an agreement for the detail >> if the mapping of internal phy registers would be a required operation? >> (Would such a resource allocation eventually be optional?) > > It is optional. Would you like to integrate an other patch variant then? Regards, Markus
On 26/09/2019 20:52:38+0200, Markus Elfring wrote: > >> Does this feedback indicate also an agreement for the detail > >> if the mapping of internal phy registers would be a required operation? > >> (Would such a resource allocation eventually be optional?) > > > > It is optional. > > Would you like to integrate an other patch variant then? > You have to ensure it stays optional. Also, adjust the subject so it uses the correct prefix.
diff --git a/drivers/net/phy/mdio-mscc-miim.c b/drivers/net/phy/mdio-mscc-miim.c index badbc99bedd3..b36fe81b6e6d 100644 --- a/drivers/net/phy/mdio-mscc-miim.c +++ b/drivers/net/phy/mdio-mscc-miim.c @@ -115,15 +115,10 @@ static int mscc_miim_reset(struct mii_bus *bus) static int mscc_miim_probe(struct platform_device *pdev) { - struct resource *res; struct mii_bus *bus; struct mscc_miim_dev *dev; int ret; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; - bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*dev)); if (!bus) return -ENOMEM; @@ -136,19 +131,16 @@ static int mscc_miim_probe(struct platform_device *pdev) bus->parent = &pdev->dev; dev = bus->priv; - dev->regs = devm_ioremap_resource(&pdev->dev, res); + dev->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(dev->regs)) { dev_err(&pdev->dev, "Unable to map MIIM registers\n"); return PTR_ERR(dev->regs); } - res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (res) { - dev->phy_regs = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(dev->phy_regs)) { - dev_err(&pdev->dev, "Unable to map internal phy registers\n"); - return PTR_ERR(dev->phy_regs); - } + dev->phy_regs = devm_platform_ioremap_resource(pdev, 1); + if (IS_ERR(dev->phy_regs)) { + dev_err(&pdev->dev, "Unable to map internal phy registers\n"); + return PTR_ERR(dev->phy_regs); } ret = of_mdiobus_register(bus, pdev->dev.of_node);