From patchwork Fri Apr 6 16:40:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Mattock X-Patchwork-Id: 151212 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1F3EDB709A for ; Sat, 7 Apr 2012 02:40:45 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754849Ab2DFQka (ORCPT ); Fri, 6 Apr 2012 12:40:30 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:58082 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754348Ab2DFQk3 (ORCPT ); Fri, 6 Apr 2012 12:40:29 -0400 Received: by yenl12 with SMTP id l12so1316385yen.19 for ; Fri, 06 Apr 2012 09:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=yuiF9ekhvjOkyxcBUyKDR1/Y+jWTgcTlcqaS/pN5ynI=; b=RMOHHiCl1ZGOXVWNoAg905dgo2gKwM01WxLsCvtetWkoOnMWzpEfLB0kHMXjoh6yiZ o2ntq5MihX1vF7g7vne3S9KdPAijq7u95Atuy/B/8L82t/LFzHJw5u597O/r+LNEMWlg Lq88EfxxSlOBcN/RoN4yrlarADPiuwYmOYC4xNTvedgfGLI2vVAXZvcnyXeyMClWpIoS s8IKAVLTCq5qpO8aNO9/K3dCD3dzLQBT+Ev2ZpBglAvRWjT9Pii2B9nLW9tVEwLHpDe8 x0k82bV4kvH8U1iJO15gOU5+gY2aAgvJCL/1jp3mMxWLqbiAjMhhAfa7au78MDB3odkp 9VZQ== Received: by 10.60.18.197 with SMTP id y5mr9841250oed.58.1333730428290; Fri, 06 Apr 2012 09:40:28 -0700 (PDT) Received: from [172.16.1.121] ([71.20.133.154]) by mx.google.com with ESMTPS id ig6sm7699344obb.15.2012.04.06.09.40.23 (version=SSLv3 cipher=OTHER); Fri, 06 Apr 2012 09:40:26 -0700 (PDT) Message-ID: <4F7F1C74.7080009@gmail.com> Date: Fri, 06 Apr 2012 09:40:20 -0700 From: "Justin P. Mattock" User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Sujith Manoharan CC: Mohammed Shafi , Linux-wireless , Felix Fietkau , linux-kernel@vger.kernel.org, Linux-netdev Subject: Re: ath: DMA failed to stop in 10 ms AR_CR=0x00000024 AR_DIAG_SW=0x02000020 DMADBG_7=0x00008040 References: <4F576FD5.2050208@gmail.com> <4F577D9B.7020402@gmail.com> <4F579A88.6030503@openwrt.org> <4F61F551.5010608@gmail.com> <4F639851.5080500@gmail.com> <4F674616.8080103@gmail.com> <4F674FF5.2060406@gmail.com> <4F6751B2.1030809@openwrt.org> <4F681B78.9000207@gmail.com> <4F68235C.5090701@gmail.com> <4F682555.3020502@gmail.com> <20328.16366.166909.255035@gargle.gargle.HOWL> <4F6FA388.9080408@gmail.com> <20337.9030.686697.228453@gargle.gargle.HOWL> In-Reply-To: <20337.9030.686697.228453@gargle.gargle.HOWL> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/26/2012 07:17 PM, Sujith Manoharan wrote: > Justin P. Mattock wrote: >> I would have to say this patch above does get rid of this crash I was >> seeing. as a quick test I simply connect to a WPA network, then connect >> to an open network going back and forth triggers this freeze for me >> after applying this I am able to toggle back and forth without a freeze. > > Thanks for verifying. > > Sujith > From going through the warning message I was playing around and am looking at: AH_UNPLUGGED .. seems if I remove this from the code I have not seen this warning message. is there something wrong with AH_UNPLUGGED = 0x2 ? is this the wrong address(0x2)? the patch that I was using is: From ea8a7d6ecf8b0706f3f0521cd22cc359b20b9373 Mon Sep 17 00:00:00 2001 From: "Justin P. Mattock" Date: Sun, 25 Mar 2012 21:53:31 -0700 Subject: [PATCH] ath_test Signed-off-by: Justin P. Mattock --- drivers/net/wireless/ath/ath9k/recv.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c index f4ae3ba..d887cee 100644 --- a/drivers/net/wireless/ath/ath9k/recv.c +++ b/drivers/net/wireless/ath/ath9k/recv.c @@ -523,8 +523,7 @@ bool ath_stoprecv(struct ath_softc *sc) sc->rx.rxlink = NULL; spin_unlock_bh(&sc->rx.rxbuflock); - if (!(ah->ah_flags & AH_UNPLUGGED) && - unlikely(!stopped)) { + if (!(ah->ah_flags) && unlikely(!stopped)) { ath_err(ath9k_hw_common(sc->sc_ah), "Could not stop RX, we could be " "confusing the DMA engine when we start RX up\n");