From patchwork Tue Mar 27 13:27:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: danborkmann@iogearbox.net X-Patchwork-Id: 148948 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EAAC1B7048 for ; Wed, 28 Mar 2012 00:47:30 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754324Ab2C0NrM (ORCPT ); Tue, 27 Mar 2012 09:47:12 -0400 Received: from www62.your-server.de ([213.133.104.62]:50240 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754300Ab2C0NrG (ORCPT ); Tue, 27 Mar 2012 09:47:06 -0400 X-Greylist: delayed 1142 seconds by postgrey-1.27 at vger.kernel.org; Tue, 27 Mar 2012 09:47:06 EDT Received: from [78.46.4.229] (helo=sslproxy03.your-server.de) by www62.your-server.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.74) (envelope-from ) id 1SCWRP-0003o4-2s; Tue, 27 Mar 2012 15:28:03 +0200 Received: from [195.176.113.14] by sslproxy03.your-server.de with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1SCWNF-00049o-Ap; Tue, 27 Mar 2012 15:23:45 +0200 Message-ID: <4F71C05C.4040300@iogearbox.net> Date: Tue, 27 Mar 2012 15:27:56 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20111110 Icedove/3.0.11 MIME-Version: 1.0 To: Ralf Baechle CC: "David S. Miller" , "netdev@vger.kernel.org" Subject: [PATCH] rose_dev: fix memcpy-bug in rose_set_mac_address X-Authenticated-Sender: danborkmann@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.97.3/14706/Tue Mar 27 12:27:45 2012) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes a small bug in rose_set_mac_address. If the current and new MAC addresses match, then nothing needs to be done. However memcpy was used instead of memcmp for comparison. The patch is against the latest net-tree. Signed-off-by: Daniel Borkmann Cc: Ralf Baechle --- net/rose/rose_dev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/rose/rose_dev.c b/net/rose/rose_dev.c index 178ff4f..3c5ce5e 100644 --- a/net/rose/rose_dev.c +++ b/net/rose/rose_dev.c @@ -96,7 +96,7 @@ static int rose_set_mac_address(struct net_device *dev, void *addr) struct sockaddr *sa = addr; int err; - if (!memcpy(dev->dev_addr, sa->sa_data, dev->addr_len)) + if (!memcmp(dev->dev_addr, sa->sa_data, dev->addr_len)) return 0; if (dev->flags & IFF_UP) {