diff mbox

[iproute2,11/11] Fix file descriptor leak on error in read_igmp()

Message ID 4E89D3BC.5050206@intra2net.com
State Accepted, archived
Delegated to: stephen hemminger
Headers show

Commit Message

Thomas Jarosch Oct. 3, 2011, 3:24 p.m. UTC 
Detected by cppcheck.

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---
 ip/ipmaddr.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Comments

stephen hemminger Oct. 7, 2011, 6:28 p.m. UTC | #1 
All these are applied and pushed to (temporary) github repo.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/ip/ipmaddr.c b/ip/ipmaddr.c
index 5a52c85..3ae9478 100644
--- a/ip/ipmaddr.c
+++ b/ip/ipmaddr.c
@@ -128,8 +128,10 @@  void read_igmp(struct ma_info **result_p)
 	if (!fp)
 		return;
 	memset(&m, 0, sizeof(m));
-	if (!fgets(buf, sizeof(buf), fp))
+	if (!fgets(buf, sizeof(buf), fp)) {
+		fclose(fp);
 		return;
+	}
 
 	m.addr.family = AF_INET;
 	m.addr.bitlen = 32;