From patchwork Mon Oct 3 15:23:53 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Jarosch X-Patchwork-Id: 117471 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 074EFB6F71 for ; Tue, 4 Oct 2011 02:32:02 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932214Ab1JCPb6 (ORCPT ); Mon, 3 Oct 2011 11:31:58 -0400 Received: from rs04.intra2net.com ([85.214.66.2]:59721 "EHLO rs04.intra2net.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755664Ab1JCPby (ORCPT ); Mon, 3 Oct 2011 11:31:54 -0400 Received: from intranator.m.i2n (unknown [172.16.1.99]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by rs04.intra2net.com (Postfix) with ESMTP id DC499220159 for ; Mon, 3 Oct 2011 17:26:16 +0200 (CEST) Received: from localhost (intranator.m.i2n [127.0.0.1]) by localhost (Postfix) with ESMTP id 9C7DE2AC58 for ; Mon, 3 Oct 2011 17:26:16 +0200 (CEST) X-Virus-Scanned: by Intranator (www.intra2net.com) with AMaViS and F-Secure AntiVirus (fsavdb 2011-10-03_03) X-Spam-Status: X-Spam-Level: 0 Received: from pikkukde.a.i2n (unknown [192.168.12.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by intranator.m.i2n (Postfix) with ESMTPS id BC5EF2AC53 for ; Mon, 3 Oct 2011 17:26:14 +0200 (CEST) Message-ID: <4E89D389.9080208@intra2net.com> Date: Mon, 03 Oct 2011 17:23:53 +0200 From: Thomas Jarosch User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.22) Gecko/20110906 Fedora/3.1.14-1.fc14 Thunderbird/3.1.14 MIME-Version: 1.0 To: netdev@vger.kernel.org Subject: [iproute2 PATCH 07/11] Fix file descriptor leak on error in iproute_flush_cache() Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Detected by cppcheck. Signed-off-by: Thomas Jarosch --- ip/iproute.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 21e1a4b..15b36e8 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -1057,6 +1057,7 @@ static int iproute_flush_cache(void) if ((write (flush_fd, (void *)buffer, len)) < len) { fprintf (stderr, "Cannot flush routing cache\n"); + close(flush_fd); return -1; } close(flush_fd);