From patchwork Mon Oct 3 15:23:18 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Jarosch X-Patchwork-Id: 117464 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 717ADB6F75 for ; Tue, 4 Oct 2011 02:26:32 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932195Ab1JCP0X (ORCPT ); Mon, 3 Oct 2011 11:26:23 -0400 Received: from re04.intra2net.com ([82.165.46.26]:39571 "EHLO re04.intra2net.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756489Ab1JCP0P (ORCPT ); Mon, 3 Oct 2011 11:26:15 -0400 Received: from intranator.m.i2n (unknown [172.16.1.99]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by re04.intra2net.com (Postfix) with ESMTP id 6451830154 for ; Mon, 3 Oct 2011 17:26:14 +0200 (CEST) Received: from localhost (intranator.m.i2n [127.0.0.1]) by localhost (Postfix) with ESMTP id 36C632AC58 for ; Mon, 3 Oct 2011 17:26:14 +0200 (CEST) X-Virus-Scanned: by Intranator (www.intra2net.com) with AMaViS and F-Secure AntiVirus (fsavdb 2011-10-03_03) X-Spam-Status: X-Spam-Level: 0 Received: from pikkukde.a.i2n (unknown [192.168.12.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by intranator.m.i2n (Postfix) with ESMTPS id 47F7A2AC57 for ; Mon, 3 Oct 2011 17:26:13 +0200 (CEST) Message-ID: <4E89D366.3060009@intra2net.com> Date: Mon, 03 Oct 2011 17:23:18 +0200 From: Thomas Jarosch User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.22) Gecko/20110906 Fedora/3.1.14-1.fc14 Thunderbird/3.1.14 MIME-Version: 1.0 To: netdev@vger.kernel.org Subject: [iproute2 PATCH 04/11] Fix wrong sanity check in choke_parse_opt() Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Detected by cppcheck. Signed-off-by: Thomas Jarosch --- tc/q_choke.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tc/q_choke.c b/tc/q_choke.c index 6e54cb7..04a864f 100644 --- a/tc/q_choke.c +++ b/tc/q_choke.c @@ -122,7 +122,7 @@ static int choke_parse_opt(struct qdisc_util *qu, int argc, char **argv, return -1; } - if (opt.qth_min > opt.qth_min) { + if (opt.qth_min >= opt.qth_max) { fprintf(stderr, "\"min\" is not smaller than \"max\"\n"); return -1; }