From patchwork Mon Nov 29 06:53:55 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shan Wei X-Patchwork-Id: 73371 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9D9131007D1 for ; Mon, 29 Nov 2010 17:55:42 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753886Ab0K2Gzi (ORCPT ); Mon, 29 Nov 2010 01:55:38 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:59679 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751275Ab0K2Gzi (ORCPT ); Mon, 29 Nov 2010 01:55:38 -0500 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id 32307170F88; Mon, 29 Nov 2010 14:55:35 +0800 (CST) Received: from mailserver.fnst.cn.fujitus.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id oAT6oxaA000307; Mon, 29 Nov 2010 14:50:59 +0800 Received: from [10.167.225.31] ([10.167.225.31]) by mailserver.fnst.cn.fujitus.com (Lotus Domino Release 8.5.1FP4) with ESMTP id 2010112914554701-117215 ; Mon, 29 Nov 2010 14:55:47 +0800 Message-ID: <4CF34E03.8020504@cn.fujitsu.com> Date: Mon, 29 Nov 2010 14:53:55 +0800 From: Shan Wei User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13pre) Gecko/20101113 Shredder/3.1.7pre MIME-Version: 1.0 To: David Miller CC: Network-Maillist , Shan Wei Subject: [PATCH 2/3] net: snmp: fix the wrong ICMP_MIB_MAX value X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2010-11-29 14:55:47, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2010-11-29 14:55:47, Serialize complete at 2010-11-29 14:55:47 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org __ICMP_MIB_MAX is equal to the total number of icmp mib, So no need to add 1. This wastes 4/8 bytes memory. Signed-off-by: Shan Wei --- include/net/snmp.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/include/net/snmp.h b/include/net/snmp.h index 835c587..762e2ab 100644 --- a/include/net/snmp.h +++ b/include/net/snmp.h @@ -60,8 +60,7 @@ struct ipstats_mib { }; /* ICMP */ -#define ICMP_MIB_MAX (__ICMP_MIB_MAX + 1) - +#define ICMP_MIB_MAX __ICMP_MIB_MAX struct icmp_mib { unsigned long mibs[ICMP_MIB_MAX]; };