From patchwork Sun Sep 20 18:19:46 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Nicolas_de_Peslo=C3=BCan?= X-Patchwork-Id: 33964 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 608A9B7B6F for ; Mon, 21 Sep 2009 04:20:04 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754737AbZITST4 (ORCPT ); Sun, 20 Sep 2009 14:19:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754767AbZITSTy (ORCPT ); Sun, 20 Sep 2009 14:19:54 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]:37023 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752782AbZITSTy (ORCPT ); Sun, 20 Sep 2009 14:19:54 -0400 Received: from smtp6-g21.free.fr (localhost [127.0.0.1]) by smtp6-g21.free.fr (Postfix) with ESMTP id 8D61CE081BA; Sun, 20 Sep 2009 20:19:48 +0200 (CEST) Received: from [192.168.0.101] (eab95-4-88-175-177-37.fbx.proxad.net [88.175.177.37]) by smtp6-g21.free.fr (Postfix) with ESMTP id 63DDAE08162; Sun, 20 Sep 2009 20:19:46 +0200 (CEST) Message-ID: <4AB67242.6060803@free.fr> Date: Sun, 20 Sep 2009 20:19:46 +0200 From: =?ISO-8859-1?Q?Nicolas_de_Peslo=FCan?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707) MIME-Version: 1.0 To: netdev@vger.kernel.org CC: David Miller , Jay Vosburgh , bonding-devel@lists.sourceforge.net Subject: [PATCH net-next-2.6] bonding: remove useless assignment Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The variable old_active is first set to bond->curr_active_slave. Then, it is unconditionally set to new_active, without being used in between. The first assignment, having no side effect, is useless. Signed-off-by: Nicolas de Pesloüan Reviewed-by: Jiri Pirko --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index a7e731f..fce7233 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1084,7 +1084,7 @@ static struct slave *bond_find_best_slave(struct bonding *bond) int mintime = bond->params.updelay; int i; - new_active = old_active = bond->curr_active_slave; + new_active = bond->curr_active_slave; if (!new_active) { /* there were no active slaves left */ if (bond->slave_cnt > 0) /* found one slave */