From patchwork Sat Aug 29 16:45:09 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver Hartkopp X-Patchwork-Id: 32507 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id EA2C9B70CF for ; Sun, 30 Aug 2009 02:45:25 +1000 (EST) Received: by ozlabs.org (Postfix) id DCD3BDDD0B; Sun, 30 Aug 2009 02:45:25 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 7BB49DDD01 for ; Sun, 30 Aug 2009 02:45:25 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751580AbZH2QpK (ORCPT ); Sat, 29 Aug 2009 12:45:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751477AbZH2QpK (ORCPT ); Sat, 29 Aug 2009 12:45:10 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.162]:32837 "EHLO mo-p00-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbZH2QpJ (ORCPT ); Sat, 29 Aug 2009 12:45:09 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1251564309; l=1023; s=domk; d=hartkopp.net; h=Content-Type:Subject:CC:To:MIME-Version:From:Date:X-RZG-CLASS-ID: X-RZG-AUTH; bh=4EbuNS1dI7A84+X/rJjGldHWnvg=; b=vdxeoRSFj2TnS/D0o1phAfEkDZDTx37FL4Hqe2jIqfLfGMkKfRV9rrvictfKfzevSlB CHANgbGEg4VRvDkfpYQyNc7DN6aLCwqEwHnBJ5K4ZejoGrMkGo98anu/rKcPvdxKUQ02E nlYXpQmxqa5nHMN4Z0eMVKO6f4WM4bJHCU4= X-RZG-AUTH: :I2ANY0W6W/eA95XfH/xfO6gOxLxTty/udEMngcJ/VAKW226lDNJVyuUMIjI8Orsx X-RZG-CLASS-ID: mo00 Received: from [192.168.11.10] (p5B22CEDE.dip.t-dialin.net [91.34.206.222]) by post.strato.de (klopstock mo37) (RZmta 21.0) with ESMTP id 4052cdl7TEdcHm ; Sat, 29 Aug 2009 18:45:09 +0200 (MEST) Message-ID: <4A995B15.4020303@hartkopp.net> Date: Sat, 29 Aug 2009 18:45:09 +0200 From: Oliver Hartkopp User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: David Miller CC: Linux Netdev List Subject: [PATCH net-next-2.6] can: use correct NET_RX_ return values X-Enigmail-Version: 0.96.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dropped skb's should be documented by an appropriate return value. Use the correct NET_RX_DROP and NET_RX_SUCCESS values for that reason. Signed-off-by: Oliver Hartkopp diff --git a/net/can/af_can.c b/net/can/af_can.c index f9c027b..ef1c43a 100644 --- a/net/can/af_can.c +++ b/net/can/af_can.c @@ -686,11 +686,11 @@ static int can_rcv(struct sk_buff *skb, struct net_device *dev, can_stats.matches_delta++; } - return 0; + return NET_RX_SUCCESS; drop: kfree_skb(skb); - return 0; + return NET_RX_DROP; } /*