From patchwork Mon Jun 29 08:49:37 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 29265 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 37D01B707D for ; Mon, 29 Jun 2009 18:50:40 +1000 (EST) Received: by ozlabs.org (Postfix) id 2B9CADDDB6; Mon, 29 Jun 2009 18:50:40 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 8BF00DDD0B for ; Mon, 29 Jun 2009 18:50:39 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692AbZF2Iua (ORCPT ); Mon, 29 Jun 2009 04:50:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752515AbZF2Iua (ORCPT ); Mon, 29 Jun 2009 04:50:30 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:64391 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752263AbZF2Iu3 (ORCPT ); Mon, 29 Jun 2009 04:50:29 -0400 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id 09ABB17014F; Mon, 29 Jun 2009 16:55:04 +0800 (CST) Received: from fnst.cn.fujitsu.com (localhost.localdomain [127.0.0.1]) by tang.cn.fujitsu.com (8.13.1/8.13.1) with ESMTP id n5T9FFOh014303; Mon, 29 Jun 2009 17:15:15 +0800 Received: from [127.0.0.1] (unknown [10.167.141.76]) by fnst.cn.fujitsu.com (Postfix) with ESMTP id 9CF7BD402F; Mon, 29 Jun 2009 16:52:44 +0800 (CST) Message-ID: <4A488021.50002@cn.fujitsu.com> Date: Mon, 29 Jun 2009 16:49:37 +0800 From: Wei Yongjun User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: David Miller , Vlad Yasevich , Eric Dumazet CC: Netdev , linux-sctp@vger.kernel.org Subject: [PATCH] sctp: xmit sctp packet always return no route error Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) broken the sctp protocol stack, the sctp packet can never be sent out after Eric Dumazet's patch, which have typo in the sctp code. Signed-off-by: Wei Yongjun Acked-by: Eric Dumazet Acked-by: Vlad Yasevich --- net/sctp/output.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sctp/output.c b/net/sctp/output.c index b764114..b94c211 100644 --- a/net/sctp/output.c +++ b/net/sctp/output.c @@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet) } dst = dst_clone(tp->dst); skb_dst_set(nskb, dst); - if (dst) + if (!dst) goto no_route; /* Build the SCTP header. */