From patchwork Tue Jun 23 19:26:11 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfgang Grandegger X-Patchwork-Id: 29087 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 7F34AB70AB for ; Wed, 24 Jun 2009 05:26:25 +1000 (EST) Received: by ozlabs.org (Postfix) id 701E2DDDF0; Wed, 24 Jun 2009 05:26:25 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id F41D8DDDEE for ; Wed, 24 Jun 2009 05:26:24 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754275AbZFWT0O (ORCPT ); Tue, 23 Jun 2009 15:26:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753955AbZFWT0O (ORCPT ); Tue, 23 Jun 2009 15:26:14 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:47443 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753878AbZFWT0N (ORCPT ); Tue, 23 Jun 2009 15:26:13 -0400 Received: from mail01.m-online.net (mail.m-online.net [192.168.3.149]) by mail-out.m-online.net (Postfix) with ESMTP id DF5A91C001CA; Tue, 23 Jun 2009 21:26:14 +0200 (CEST) X-Auth-Info: GWx2JHzxBtgJ+OJImfX7G/1ZssN4tVXCdtHqoAN7+ho= Received: from lancy.denx.de (p4FE6514D.dip.t-dialin.net [79.230.81.77]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mnet-online.de (Postfix) with ESMTP id EC797902F2; Tue, 23 Jun 2009 21:26:13 +0200 (CEST) Message-ID: <4A412C53.8050607@grandegger.com> Date: Tue, 23 Jun 2009 21:26:11 +0200 From: Wolfgang Grandegger User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Heiko Carstens CC: David Miller , Oliver Hartkopp , Martin Schwidefsky , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] can: let SJA1000 driver depend on HAS_IOMEM References: <20090623073120.GA5955@osiris.boeblingen.de.ibm.com> In-Reply-To: <20090623073120.GA5955@osiris.boeblingen.de.ibm.com> X-Enigmail-Version: 0.95.7 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Heiko Carstens wrote: > From: Heiko Carstens > > Fixes this compile error on s390: > > drivers/net/can/sja1000/sja1000_platform.c: In function 'sp_read_reg': > drivers/net/can/sja1000/sja1000_platform.c:42: error: implicit declaration of function 'ioread8' > drivers/net/can/sja1000/sja1000_platform.c: In function 'sp_write_reg': > drivers/net/can/sja1000/sja1000_platform.c:47: error: implicit declaration of function 'iowrite8' > drivers/net/can/sja1000/sja1000_platform.c: In function 'sp_probe': > drivers/net/can/sja1000/sja1000_platform.c:79: error: implicit declaration of function 'ioremap_nocache' > > Cc: Wolfgang Grandegger > Cc: Oliver Hartkopp > Signed-off-by: Heiko Carstens > --- > drivers/net/can/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/drivers/net/can/Kconfig > =================================================================== > --- linux-2.6.orig/drivers/net/can/Kconfig > +++ linux-2.6/drivers/net/can/Kconfig > @@ -36,7 +36,7 @@ config CAN_CALC_BITTIMING > If unsure, say Y. > > config CAN_SJA1000 > - depends on CAN_DEV > + depends on CAN_DEV && HAS_IOMEM > tristate "Philips SJA1000" > ---help--- > Driver for the SJA1000 CAN controllers from Philips or NXP Hm, this Kconfig entry is not directly responsible for building sja1000_platform.o. It builds sja1000.o, which does not rely on HAS_IOMEM. It should be added to "config CAN_SJA1000_PLATFORM" instead. Does the patch below work for you? Wolfgang. --- drivers/net/can/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: net-next-2.6/drivers/net/can/Kconfig =================================================================== --- net-next-2.6.orig/drivers/net/can/Kconfig +++ net-next-2.6/drivers/net/can/Kconfig @@ -42,7 +42,7 @@ config CAN_SJA1000 Driver for the SJA1000 CAN controllers from Philips or NXP config CAN_SJA1000_PLATFORM - depends on CAN_SJA1000 + depends on HAS_IOMEM && CAN_SJA1000 tristate "Generic Platform Bus based SJA1000 driver" ---help--- This driver adds support for the SJA1000 chips connected to