From patchwork Tue May 19 19:44:14 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 27416 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id E4EBAB7067 for ; Wed, 20 May 2009 05:44:31 +1000 (EST) Received: by ozlabs.org (Postfix) id D8EA2DE0F9; Wed, 20 May 2009 05:44:31 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 7A565DE0F1 for ; Wed, 20 May 2009 05:44:31 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753735AbZESToX (ORCPT ); Tue, 19 May 2009 15:44:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753366AbZESToW (ORCPT ); Tue, 19 May 2009 15:44:22 -0400 Received: from gw1.cosmosbay.com ([212.99.114.194]:50711 "EHLO gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752484AbZESToW convert rfc822-to-8bit (ORCPT ); Tue, 19 May 2009 15:44:22 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) by gw1.cosmosbay.com (8.13.7/8.13.7) with ESMTP id n4JJiFBc015276; Tue, 19 May 2009 21:44:15 +0200 Message-ID: <4A130C0E.6000507@cosmosbay.com> Date: Tue, 19 May 2009 21:44:14 +0200 From: Eric Dumazet User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: David Miller CC: netdev@vger.kernel.org, jarkao2@gmail.com, kaber@trash.net Subject: Re: [PATCH, v2] net: release dst entry in dev_hard_start_xmit() References: <4A092F59.7020900@cosmosbay.com> <4A093178.9020105@cosmosbay.com> <4A09CD6B.5070604@cosmosbay.com> <20090518.221956.153457626.davem@davemloft.net> In-Reply-To: <20090518.221956.153457626.davem@davemloft.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (gw1.cosmosbay.com [0.0.0.0]); Tue, 19 May 2009 21:44:15 +0200 (CEST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org David Miller a écrit : > From: Eric Dumazet > Date: Tue, 12 May 2009 21:26:35 +0200 > >> [PATCH] net: release dst entry in dev_hard_start_xmit() > ... >> Signed-off-by: Eric Dumazet > > Applied, thanks Eric. > > Eric, please followup and double-check the pppoe paths > that Jarek mentioned. I never saw that fully resolved. > [PATCH] ppp: unset IFF_XMIT_DST_RELEASE in ppp_setup() Jarek pointed pppoe can call back dev_queue_xmit(), and might need skb->dst, so its safer to unset IFF_XMIT_DST_RELEASE on ppp devices. Signed-off-by: Eric Dumazet --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c index 8ee9142..639d11b 100644 --- a/drivers/net/ppp_generic.c +++ b/drivers/net/ppp_generic.c @@ -1054,6 +1054,7 @@ static void ppp_setup(struct net_device *dev) dev->type = ARPHRD_PPP; dev->flags = IFF_POINTOPOINT | IFF_NOARP | IFF_MULTICAST; dev->features |= NETIF_F_NETNS_LOCAL; + dev->priv_flags &= ~IFF_XMIT_DST_RELEASE; } /*