From patchwork Wed Apr 29 17:15:27 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Breno Leitao X-Patchwork-Id: 26622 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 17CF8B7079 for ; Thu, 30 Apr 2009 03:16:52 +1000 (EST) Received: by ozlabs.org (Postfix) id D2D7DDDECF; Thu, 30 Apr 2009 03:16:51 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 71B84DDE9E for ; Thu, 30 Apr 2009 03:16:51 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758783AbZD2RPh (ORCPT ); Wed, 29 Apr 2009 13:15:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757923AbZD2RPh (ORCPT ); Wed, 29 Apr 2009 13:15:37 -0400 Received: from e24smtp01.br.ibm.com ([32.104.18.85]:50251 "EHLO e24smtp01.br.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758157AbZD2RPf (ORCPT ); Wed, 29 Apr 2009 13:15:35 -0400 Received: from mailhub3.br.ibm.com (mailhub3.br.ibm.com [9.18.232.110]) by e24smtp01.br.ibm.com (8.13.1/8.13.1) with ESMTP id n3THW3se023228 for ; Wed, 29 Apr 2009 14:32:03 -0300 Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3THFrRb2007116 for ; Wed, 29 Apr 2009 14:15:53 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3THFUmN016864 for ; Wed, 29 Apr 2009 14:15:30 -0300 Received: from [9.8.5.189] ([9.8.5.189]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n3THFTdq016739; Wed, 29 Apr 2009 14:15:29 -0300 Message-ID: <49F88B2F.4000802@linux.vnet.ibm.com> Date: Wed, 29 Apr 2009 14:15:27 -0300 From: Breno Leitao User-Agent: Thunderbird 2.0.0.21 (X11/20090409) MIME-Version: 1.0 To: e1000-devel@lists.sourceforge.net CC: netdev Subject: [PATCH net-next] ixgbe: removing unnecesary assignments Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch removes some assignment that are not necessary. Since the ret variable is declared as false during its initialization, it makes no sense to reassign false to it again. Signed-off-by: Breno Leitao --- drivers/net/ixgbe/ixgbe_main.c | 12 ------------ 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index 5020f11..c238677 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c @@ -2775,8 +2775,6 @@ static inline bool ixgbe_set_dcb_queues(struct ixgbe_adapter *adapter) adapter->num_tx_queues = adapter->ring_feature[RING_F_DCB].indices; ret = true; - } else { - ret = false; } return ret; @@ -2802,8 +2800,6 @@ static inline bool ixgbe_set_rss_queues(struct ixgbe_adapter *adapter) adapter->num_tx_queues = adapter->ring_feature[RING_F_RSS].indices; ret = true; - } else { - ret = false; } return ret; @@ -2910,8 +2906,6 @@ static inline bool ixgbe_cache_ring_rss(struct ixgbe_adapter *adapter) for (i = 0; i < adapter->num_tx_queues; i++) adapter->tx_ring[i].reg_idx = i; ret = true; - } else { - ret = false; } return ret; @@ -2986,14 +2980,8 @@ static inline bool ixgbe_cache_ring_dcb(struct ixgbe_adapter *adapter) adapter->rx_ring[i].reg_idx = i << 5; ret = true; - } else { - ret = false; } - } else { - ret = false; } - } else { - ret = false; } return ret;