| Message ID | 49C354B5.3060404@cosmosbay.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Eric Dumazet <dada1@cosmosbay.com> Date: Fri, 20 Mar 2009 09:32:53 +0100 > There is no point to use prefetch() call here. > start_xmit() is a function like others... > > Signed-off-by: Eric Dumazet <dada1@cosmosbay.com> Yes but the operation pointer might not be in the CPU cache at this time? And if it's not we can get it into the cpu whilst we do other processing, such as the dev_queue_xmit_nit() stuff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/dev.c b/net/core/dev.c index c013031..c97e27d 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1670,7 +1670,6 @@ int dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev, const struct net_device_ops *ops = dev->netdev_ops; int rc; - prefetch(&dev->netdev_ops->ndo_start_xmit); if (likely(!skb->next)) { if (!list_empty(&ptype_all)) dev_queue_xmit_nit(skb, dev);
There is no point to use prefetch() call here. start_xmit() is a function like others... Signed-off-by: Eric Dumazet <dada1@cosmosbay.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html