From patchwork Wed Feb 25 10:42:22 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 23706 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 3F1A7DDDB6 for ; Wed, 25 Feb 2009 21:43:06 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759779AbZBYKnA (ORCPT ); Wed, 25 Feb 2009 05:43:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759035AbZBYKnA (ORCPT ); Wed, 25 Feb 2009 05:43:00 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:52994 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1756796AbZBYKnA (ORCPT ); Wed, 25 Feb 2009 05:43:00 -0500 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id 667C3170116; Wed, 25 Feb 2009 18:55:19 +0800 (CST) Received: from fnst.cn.fujitsu.com (localhost.localdomain [127.0.0.1]) by tang.cn.fujitsu.com (8.13.1/8.13.1) with ESMTP id n1PAiL5w010109; Wed, 25 Feb 2009 18:44:21 +0800 Received: from [127.0.0.1] (unknown [10.167.141.76]) by fnst.cn.fujitsu.com (Postfix) with ESMTP id E733DDC457; Wed, 25 Feb 2009 18:43:04 +0800 (CST) Message-ID: <49A5208E.3050302@cn.fujitsu.com> Date: Wed, 25 Feb 2009 18:42:22 +0800 From: Wei Yongjun User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: netdev@vger.kernel.org Subject: [PATCH] llc: remove some pointless conditionals before kfree_skb() Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove some pointless conditionals before kfree_skb(). Signed-off-by: Wei Yongjun --- net/llc/llc_conn.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/llc/llc_conn.c b/net/llc/llc_conn.c index 5c6d89c..3477624 100644 --- a/net/llc/llc_conn.c +++ b/net/llc/llc_conn.c @@ -332,8 +332,7 @@ int llc_conn_remove_acked_pdus(struct sock *sk, u8 nr, u16 *how_many_unacked) for (i = 0; i < pdu_pos && i < q_len; i++) { skb = skb_dequeue(&llc->pdu_unack_q); - if (skb) - kfree_skb(skb); + kfree_skb(skb); nbr_acked++; } out: