From patchwork Wed Feb 25 10:35:44 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 23701 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 78460DDED5 for ; Wed, 25 Feb 2009 21:36:44 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762212AbZBYKgS (ORCPT ); Wed, 25 Feb 2009 05:36:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757383AbZBYKgR (ORCPT ); Wed, 25 Feb 2009 05:36:17 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:49753 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1760678AbZBYKgQ (ORCPT ); Wed, 25 Feb 2009 05:36:16 -0500 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id F27FE17012D; Wed, 25 Feb 2009 18:48:40 +0800 (CST) Received: from fnst.cn.fujitsu.com (localhost.localdomain [127.0.0.1]) by tang.cn.fujitsu.com (8.13.1/8.13.1) with ESMTP id n1PAbg9K009869; Wed, 25 Feb 2009 18:37:43 +0800 Received: from [127.0.0.1] (unknown [10.167.141.76]) by fnst.cn.fujitsu.com (Postfix) with ESMTP id 5FBF1EC007; Wed, 25 Feb 2009 18:36:26 +0800 (CST) Message-ID: <49A51F00.9090401@cn.fujitsu.com> Date: Wed, 25 Feb 2009 18:35:44 +0800 From: Wei Yongjun User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: David Miller CC: netdev@vger.kernel.org Subject: [PATCH] can: remove some pointless conditionals before kfree_skb() Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove some pointless conditionals before kfree_skb(). Signed-off-by: Wei Yongjun --- net/can/af_can.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/can/af_can.c b/net/can/af_can.c index d90e8dd..547bafc 100644 --- a/net/can/af_can.c +++ b/net/can/af_can.c @@ -273,8 +273,7 @@ int can_send(struct sk_buff *skb, int loop) err = net_xmit_errno(err); if (err) { - if (newskb) - kfree_skb(newskb); + kfree_skb(newskb); return err; }