From patchwork Tue Jul 23 09:55:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Wu X-Patchwork-Id: 261021 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 405D22C00BF for ; Tue, 23 Jul 2013 19:56:08 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756252Ab3GWJ4E (ORCPT ); Tue, 23 Jul 2013 05:56:04 -0400 Received: from mail-bk0-f54.google.com ([209.85.214.54]:34338 "EHLO mail-bk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756075Ab3GWJ4C (ORCPT ); Tue, 23 Jul 2013 05:56:02 -0400 Received: by mail-bk0-f54.google.com with SMTP id it16so2915164bkc.13 for ; Tue, 23 Jul 2013 02:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:user-agent:mime-version :content-transfer-encoding:content-type; bh=8L3qQrjCchLigDNjmNstSnywzbvMdz1GQDCgTWdw1UA=; b=R3m9aqwzy7mydfGe5RJf9JrVboRfS54x7Y3zc31vabAY7fTOqVX/RUlK6ICU0bubK/ qw9ZA+PNzCTDLGHk8DHdywK04dyFh7FaxwRmNz4Y9uBnRVoC51jcbPMCposlyIGKNLZj vbHD5cTSW7NSL1DKMvPHHyD1u9RQE3ItUEfqVqNka8kX6Klm6LXny9OZoDPTuphEOZ7I BvFizSDwLdiLbwcEXCym8RYPY4EL8oe4pOs5mt9b7UlY+App9mhNOlGr+7NdZmnikwAP YbBUbdNvPmwocgHOTNiZyYZs5m4kGS5QUhXbUJ57OjiZ8JguIYLr+aRg+uNYsVdSUs/l VjRQ== X-Received: by 10.204.76.72 with SMTP id b8mr4654923bkk.67.1374573361032; Tue, 23 Jul 2013 02:56:01 -0700 (PDT) Received: from al.localnet (al.lekensteyn.nl. [2001:470:1f15:b83::c0d1:f1ed]) by mx.google.com with ESMTPSA id pc8sm3225796bkb.10.2013.07.23.02.55.58 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Jul 2013 02:56:00 -0700 (PDT) From: Peter Wu To: Francois Romieu Cc: David Miller , netdev@vger.kernel.org, nic_swsd@realtek.com Subject: r8169: remove "PHY reset until link up" log spam Date: Tue, 23 Jul 2013 11:55:57 +0200 Message-ID: <4961229.bXDGvH0dpz@al> User-Agent: KMail/4.10.5 (Linux/3.10.0-1-custom; KDE/4.10.5; x86_64; ; ) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This message was added in commit a7154cb8 (June 2004) and is printed every ten seconds when no cable is connected. Signed-off-by: Peter Wu --- Using ethtool to silence *all* link warnings is still a manual operation, in my opinion not acceptable so let's remove this message. The r8169 constantly resets the device when no link is connected, contrary the r8168 vendor driver which only resets the link when some PCI config fields have been modified. As the current reset logic in r8168 seems to work for broken device (which I do not have have and therefore cannot test), I did not attempt to "clean this up". --- drivers/net/ethernet/realtek/r8169.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 880015c..63f04af 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -3689,8 +3689,6 @@ static void rtl_phy_work(struct rtl8169_private *tp) if (tp->link_ok(ioaddr)) return; - netif_warn(tp, link, tp->dev, "PHY reset until link up\n"); - tp->phy_reset_enable(tp); out_mod_timer: