diff mbox series

[v2,4/4] net: emac: add deprecation notice to emac custom phy users

Message ID 478ef8b0bfd3fe914bdc52ca022d903c98884b04.1540206214.git.chunkeey@gmail.com
State Changes Requested, archived
Delegated to: David Miller
Headers show
Series [v2,1/4] net: emac: implement 802.1Q VLAN TX tagging support | expand

Commit Message

Christian Lamparter Oct. 22, 2018, 11:04 a.m. UTC 
From: Christian Lamparter <chunkeey@googlemail.com>

This patch starts the deprecation process of emac's small library of
supported phys by adding a message to inform all remaining users to
start looking into converting their platform's device-tree to PHYLIB.

EMAC's phy.c support is limited to mostly single ethernet transceivers:
CIS8201, BCM5248, ET1011C, Marvell 88E1111 and 88E1112, AR8035.

And Linux has dedicated PHYLIB drivers for all but the BCM5248 which
can be supported by the generic phy driver.

Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
---
 drivers/net/ethernet/ibm/emac/phy.c | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox series

Patch

diff --git a/drivers/net/ethernet/ibm/emac/phy.c b/drivers/net/ethernet/ibm/emac/phy.c
index aa070c063e48..143b4c688ee9 100644
--- a/drivers/net/ethernet/ibm/emac/phy.c
+++ b/drivers/net/ethernet/ibm/emac/phy.c
@@ -496,6 +496,7 @@  static struct mii_phy_def ar8035_phy_def = {
 };
 
 static struct mii_phy_def *mii_phy_table[] = {
+	/* DEPRECATED: Do not add any new PHY drivers to this list. */
 	&et1011c_phy_def,
 	&cis8201_phy_def,
 	&bcm5248_phy_def,
@@ -512,6 +513,9 @@  int emac_mii_phy_probe(struct mii_phy *phy, int address)
 	int i;
 	u32 id;
 
+	pr_info("EMAC's custom phy code has been deprecated.\n"
+		"Please convert your EMAC device to PHYLIB.\n");
+
 	phy->autoneg = AUTONEG_DISABLE;
 	phy->advertising = 0;
 	phy->address = address;