From patchwork Mon Jul 27 17:24:04 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karsten Keil X-Patchwork-Id: 30296 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id D91F2B7B71 for ; Tue, 28 Jul 2009 21:51:02 +1000 (EST) Received: by ozlabs.org (Postfix) id CBDDEDDD0B; Tue, 28 Jul 2009 21:51:02 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 449DDDDD04 for ; Tue, 28 Jul 2009 21:51:02 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbZG1Lu2 (ORCPT ); Tue, 28 Jul 2009 07:50:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753191AbZG1Lu1 (ORCPT ); Tue, 28 Jul 2009 07:50:27 -0400 Received: from d112a2.x-mailer.de ([212.162.53.4]:43776 "EHLO d112a2.x-mailer.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753170AbZG1LuZ (ORCPT ); Tue, 28 Jul 2009 07:50:25 -0400 Received: from [84.151.253.73] (helo=pingi) by d112.x-mailer.de with esmtpa (Exim 4.63) (envelope-from ) id 1MVlCK-0005EO-08; Tue, 28 Jul 2009 13:50:24 +0200 Message-Id: <467d0b871314c60818f541024fcacca686f3e354.1248781021.git.keil@b1-systems.de> In-Reply-To: References: Date: Mon, 27 Jul 2009 19:24:04 +0200 Subject: [PATCH 1/1] mISDN: Fix handling of receive buffer size in L1oIP From: Karsten Keil To: Linus Torvalds Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, David Miller , i4ldeveloper@listserv.isdn4linux.de, Andreas Eversberg , Arnaldo Carvalho de Melo X-Info: valid message X-Info: original Date Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andreas Eversberg The size of receive buffer pointer was used to get size of receive buffer instead of recvbuf_size itself, so only 4/8 bytes could be transfered. This is a regression to 2.6.30 introduced by commit 8c90e11e3543d7de612194a042a148caeaab5f1d mISDN: Use kernel_{send,recv}msg instead of open coding Signed-off-by: Andreas Eversberg Signed-off-by: Karsten Keil --- drivers/isdn/mISDN/l1oip_core.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/isdn/mISDN/l1oip_core.c b/drivers/isdn/mISDN/l1oip_core.c index 990e6a7..c3b661a 100644 --- a/drivers/isdn/mISDN/l1oip_core.c +++ b/drivers/isdn/mISDN/l1oip_core.c @@ -731,10 +731,10 @@ l1oip_socket_thread(void *data) while (!signal_pending(current)) { struct kvec iov = { .iov_base = recvbuf, - .iov_len = sizeof(recvbuf), + .iov_len = recvbuf_size, }; recvlen = kernel_recvmsg(socket, &msg, &iov, 1, - sizeof(recvbuf), 0); + recvbuf_size, 0); if (recvlen > 0) { l1oip_socket_parse(hc, &sin_rx, recvbuf, recvlen); } else {