From patchwork Wed Sep 20 07:01:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 816067 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qqF3udpG"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xxrKX2NQdz9s7h for ; Wed, 20 Sep 2017 17:02:40 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751779AbdITHC3 (ORCPT ); Wed, 20 Sep 2017 03:02:29 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33895 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676AbdITHC1 (ORCPT ); Wed, 20 Sep 2017 03:02:27 -0400 Received: by mail-pf0-f195.google.com with SMTP id g65so867201pfe.1; Wed, 20 Sep 2017 00:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=RI7yojwApEj4wn/NfEcfytowP6rMkDrZGPt3yOl6rlA=; b=qqF3udpGIj6BmM3wI1Q+qTvkwQbqPDOL4y/n++LnP17lcz2yPD0jfzQHRPzM9OHql1 /gpYK6FyIxCq4oMUslgTC3soPIyV2tGwxfzisKxLDo4MHH+ZGnk0NYdcsE1o48VAKwoB Xg/9rUwCWmyk+dBwZnP2v55cDEtZ7sW+SZCRSOTaa1sCGseINvQRb6oAQRYYe1QLBr56 EMneurwuMJ2JnpEpQb1y15Zi3YHh3NB3fnRxRcm2OGKYY9BozcMDEOXxveniy8Y+RBlu ZlNJML4SsZOWymsilZXaZck28u5gtOw/0ZedvCt8FQpHdVwF+crG+7vfpfcqkWQxZJVM V9Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RI7yojwApEj4wn/NfEcfytowP6rMkDrZGPt3yOl6rlA=; b=tywsl/sXYo1Qns6lQPLpd2EHgGJprNwSjZP5S20FA23U2BHRPkij05s3sfVcZJ8iN2 OPTinSKShDuemelQwUeg2Xgjz4qTryZLR1R58lItAj2fjrL9DR536nfpm6Ay2BPBzCz7 JhAUSTWncwMpDyX/A8IAe7xRsrUr50P+vefqlOB5AqZGn7jrrmsw/ioSFWpa3VZNkiK1 H22n2II1CeQGGEjmLpePoCLUjFkeUM2h38jhLGodmdthYItDogg/e3BReC30hkfhZOn2 90fbtrHjR9xz2BKikWpdBoxv0zTelzkm4E8gVXWbS8LZz1nTR18rI3dQVTXByI9UXbiE u6lw== X-Gm-Message-State: AHPjjUgBeDsCCtL2gNR2NmHEwAEGxSNlpuSTZmwYQzkw+MMFxGlsqU3d eUOU0ksTyQL/HOQRjpu8AP0= X-Google-Smtp-Source: AOwi7QCG5z/gzu76ao8Em3E06/EFdNfSw0G1bP+FsU8aAkXPwqMtJ4hebyU/JZANPaoyrb/FJtuNkg== X-Received: by 10.98.62.80 with SMTP id l77mr1164077pfa.267.1505890947256; Wed, 20 Sep 2017 00:02:27 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id 65sm5803361pgh.31.2017.09.20.00.02.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Sep 2017 00:02:26 -0700 (PDT) From: Arvind Yadav To: pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, davem@davemloft.net Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] netfilter: nf_tables: Release memory obtained by kasprintf Date: Wed, 20 Sep 2017 12:31:28 +0530 Message-Id: <385554261c080cd3fc4adc093e68366a6d3dff77.1505889128.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Free memory region, if nf_tables_set_alloc_name is not successful. Signed-off-by: Arvind Yadav --- net/netfilter/nf_tables_api.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 9299271..393e37e 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -2741,8 +2741,10 @@ static int nf_tables_set_alloc_name(struct nft_ctx *ctx, struct nft_set *set, list_for_each_entry(i, &ctx->table->sets, list) { if (!nft_is_active_next(ctx->net, i)) continue; - if (!strcmp(set->name, i->name)) + if (!strcmp(set->name, i->name)) { + kfree(set->name); return -ENFILE; + } } return 0; }