| Message ID | 3805935.iR4tgtFiHm@wasted.cogentembedded.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Jan 22, 2017 at 8:18 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Renesas SH77{34|63} manuals describe more EESIPR bits than the current > driver. Declare the new bits with the end goal of using the bit names > instead of the bare numbers for the 'sh_eth_cpu_data::eesipr_value' > initializers... > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/net/ethernet/renesas/sh_eth.h | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > Index: net-next/drivers/net/ethernet/renesas/sh_eth.h > =================================================================== > --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h > +++ net-next/drivers/net/ethernet/renesas/sh_eth.h > @@ -269,13 +269,17 @@ enum EESR_BIT { > > /* EESIPR */ > enum EESIPR_BIT { > - EESIPR_TWBIP = 0x40000000, > + EESIPR_TWB1IP = 0x80000000, > + EESIPR_TWBIP = 0x40000000, /* same as TWB0IP */ Ah, your adding it here ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 01/23/2017 10:41 AM, Geert Uytterhoeven wrote: >> Renesas SH77{34|63} manuals describe more EESIPR bits than the current >> driver. Declare the new bits with the end goal of using the bit names >> instead of the bare numbers for the 'sh_eth_cpu_data::eesipr_value' >> initializers... >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> --- >> drivers/net/ethernet/renesas/sh_eth.h | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> Index: net-next/drivers/net/ethernet/renesas/sh_eth.h >> =================================================================== >> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h >> +++ net-next/drivers/net/ethernet/renesas/sh_eth.h >> @@ -269,13 +269,17 @@ enum EESR_BIT { >> >> /* EESIPR */ >> enum EESIPR_BIT { >> - EESIPR_TWBIP = 0x40000000, >> + EESIPR_TWB1IP = 0x80000000, >> + EESIPR_TWBIP = 0x40000000, /* same as TWB0IP */ > > Ah, your adding it here ;-) Do you want me to add such comment in the 1st patch instead? > Gr{oetje,eeting}s, > > Geert MRB, Sergei
Index: net-next/drivers/net/ethernet/renesas/sh_eth.h =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h +++ net-next/drivers/net/ethernet/renesas/sh_eth.h @@ -269,13 +269,17 @@ enum EESR_BIT { /* EESIPR */ enum EESIPR_BIT { - EESIPR_TWBIP = 0x40000000, + EESIPR_TWB1IP = 0x80000000, + EESIPR_TWBIP = 0x40000000, /* same as TWB0IP */ + EESIPR_TC1IP = 0x20000000, + EESIPR_TUCIP = 0x10000000, + EESIPR_ROCIP = 0x08000000, EESIPR_TABTIP = 0x04000000, EESIPR_RABTIP = 0x02000000, EESIPR_RFCOFIP = 0x01000000, EESIPR_ADEIP = 0x00800000, EESIPR_ECIIP = 0x00400000, - EESIPR_FTCIP = 0x00200000, + EESIPR_FTCIP = 0x00200000, /* same as TC0IP */ EESIPR_TDEIP = 0x00100000, EESIPR_TFUFIP = 0x00080000, EESIPR_FRIP = 0x00040000, @@ -286,6 +290,8 @@ enum EESIPR_BIT { EESIPR_CDIP = 0x00000200, EESIPR_TROIP = 0x00000100, EESIPR_RMAFIP = 0x00000080, + EESIPR_CEEFIP = 0x00000040, + EESIPR_CELFIP = 0x00000020, EESIPR_RRFIP = 0x00000010, EESIPR_RTLFIP = 0x00000008, EESIPR_RTSFIP = 0x00000004,
Renesas SH77{34|63} manuals describe more EESIPR bits than the current driver. Declare the new bits with the end goal of using the bit names instead of the bare numbers for the 'sh_eth_cpu_data::eesipr_value' initializers... Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- drivers/net/ethernet/renesas/sh_eth.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)