From patchwork Thu Jan 31 22:35:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Machata X-Patchwork-Id: 1034497 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="Ko7TlQ0G"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43rFRp3JLrz9sDX for ; Fri, 1 Feb 2019 09:35:18 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728854AbfAaWfR (ORCPT ); Thu, 31 Jan 2019 17:35:17 -0500 Received: from mail-eopbgr70075.outbound.protection.outlook.com ([40.107.7.75]:14830 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726172AbfAaWfQ (ORCPT ); Thu, 31 Jan 2019 17:35:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CyMMke7/Hz37xGNvo6KILN8f8WPVIydWGA/1x2DJhBg=; b=Ko7TlQ0GAvgr02aFxv/6TcI2X4vQt3MGtbHjeACVWOGH738qjlweGZHDxnF0NRT841ic/C2IZCKQ0g1cFXDCOFeUQbDMfLk7D5Lv3tZ+gx6DwLb+7rLoSttkpNzKCu0SX2wSGDEPda9NHMKRj+ZTYpA/6H2lhmqYSbF2fsZ4puQ= Received: from AM6PR05MB4885.eurprd05.prod.outlook.com (20.177.34.225) by AM6PR05MB6470.eurprd05.prod.outlook.com (20.179.7.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1580.17; Thu, 31 Jan 2019 22:35:13 +0000 Received: from AM6PR05MB4885.eurprd05.prod.outlook.com ([fe80::3830:b2de:562:1fe6]) by AM6PR05MB4885.eurprd05.prod.outlook.com ([fe80::3830:b2de:562:1fe6%4]) with mapi id 15.20.1558.025; Thu, 31 Jan 2019 22:35:13 +0000 From: Petr Machata To: "netdev@vger.kernel.org" CC: Ido Schimmel Subject: [PATCH net-next 02/11] selftests: forwarding: mirror_lib: Update ping limits Thread-Topic: [PATCH net-next 02/11] selftests: forwarding: mirror_lib: Update ping limits Thread-Index: AQHUubU6GaF8+lW5HUuHcHUe53+WXQ== Date: Thu, 31 Jan 2019 22:35:12 +0000 Message-ID: <366d0fc7325cf6715148f7d57ffc3ce7c9976866.1548973731.git.petrm@mellanox.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6PR0102CA0030.eurprd01.prod.exchangelabs.com (2603:10a6:209:14::43) To AM6PR05MB4885.eurprd05.prod.outlook.com (2603:10a6:20b:b::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=petrm@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [78.45.160.211] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR05MB6470; 6:0CvNnlE/wLQ8N4+PH52RbryOKZgHioA8+GS60SGN1MZ04ayOKNu4IesZVARt118RrtcqsKv/WrOy8mujd2SVSf2MIhIT612YUt9BQx/y3a7/STrDiowbams/tpPgbjCDy7JVNpBOoPawZmkN7EumG+qcreXbVfpFbGgCtEhlq/NyJQXc1Dvez2+dCDftKuu9k0aWXFY+sI52V5fBP4OEDYVgRNmx2mkhLKDGJIQ626p4oniw9l30Ep4maeCEnsRWUXqgLiY1Cm5ZdB5Q1/ZPtXK3MFd3+PwvwXPxurHh7XqWm5BcoxxebxWfS2VJ2JXEc7HGAmTvw6NtI192HwbiMiCy5oMmC5jhaOssUp/PmVLI/ne8DiwaChpG988tXroC3QseijfwXxlw6oGMyDvZ3uL5c/SGxAP2qDIGMEtkQOH1j7VLyOiEY+JK8dO/hld6DnwacciUVMfeJBKpGqjkYQ==; 5:/RUQgBOm2IPP3xrci7ta0DQSBJqgcNFP0/TFVrjM89NKspjbjkypPoZpU01tygt77H+3Zs4XHd5LKfiTpOIAE/4VQUVOge+o1f4fVuXy8qGvlIqUWBo6JCk1El/610uqIA7zPM/PaQZMXkfsDl0yEsgBKWzWATP/92VU4liv7hbBtunhN15UA4E3Xrzrd2vg09GAESjArUkk+KssiV4quw==; 7:V+o4gvCaSLlUdKLc7O+AcOwntC1N+3bP7yemFXwNy09qfv9LzBMqGXoy34kEDjM5GN65gSy7DOX5bTg+eD86AyE3+wtiR+A7IQOttcsAMiAyvGRwa+WDP5eO7JkL0a7daC8wZyg/myIvjqrCJ766mg== x-ms-office365-filtering-correlation-id: f49503ef-9b3c-4048-6dc2-08d687cc5d2e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR05MB6470; x-ms-traffictypediagnostic: AM6PR05MB6470: x-microsoft-antispam-prvs: x-forefront-prvs: 09347618C4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(346002)(376002)(396003)(39860400002)(199004)(189003)(105586002)(99286004)(6436002)(3846002)(7736002)(86362001)(6486002)(76176011)(4326008)(6116002)(305945005)(52116002)(5640700003)(36756003)(316002)(71200400001)(256004)(14444005)(71190400001)(106356001)(6916009)(25786009)(53936002)(186003)(478600001)(476003)(2616005)(118296001)(26005)(11346002)(446003)(2351001)(486006)(6512007)(107886003)(2906002)(81156014)(8936002)(1730700003)(8676002)(14454004)(2501003)(68736007)(66066001)(81166006)(6506007)(386003)(97736004)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB6470; H:AM6PR05MB4885.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: lmS/jlrPXnyiDYlTujemYiulMVv9jxN/yaDQcMTdv81gMteE4hN3N/xSO2HZsBo8SGODWn49tlxF5dTKRwmM5XBB20xAYufvxw/YkhVcA1+i64k7hL7p+J3AsNC8U/XCEpf02hmvGRQmLroycwvTALFKxCIaVeuIwp74aAOmiZoHCqjqsd7xFnaEy32//OwM4rqG4Kis43u3IZyby+8B7RuCldmEl6gJng/hS+bYswJI4wv0fuJnzC2kXeS9KF0Nr2IGvDT5Qi2EcPbyt5XKUe2SzIw1egNRlBTKcxFMMqZYh1KA2ahABP18gmSmgzM5BSlA6lxGM676ZtwPGeWmG676AVj2Ud6/N7O0Ox/X+NOoHKUxTs+OUr12qJhfLNzUr2ifzII3H1S8RhaG9RsgP9QM+Ne/URG3+YJWUin6Da0= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f49503ef-9b3c-4048-6dc2-08d687cc5d2e X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2019 22:35:12.4454 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6470 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The current ping intervals are too short for running mirroring tests in simulator. This leads to ping sending a follow-up ping before the reply arrives, thus sending more than the requested 10 ICMP requests. Those are mirrored, and over a certain threshold the test case run is considered a failure, because too much traffic is observed. Bump interval and timeout numbers 5x in mirroring tests to address the spurious failures. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/mirror_lib.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/forwarding/mirror_lib.sh b/tools/testing/selftests/net/forwarding/mirror_lib.sh index a1c0389eb049..878f8d53327a 100644 --- a/tools/testing/selftests/net/forwarding/mirror_lib.sh +++ b/tools/testing/selftests/net/forwarding/mirror_lib.sh @@ -29,10 +29,11 @@ mirror_test() local pref=$1; shift local expect=$1; shift + local ping_timeout=$((PING_TIMEOUT * 5)) local t0=$(tc_rule_stats_get $dev $pref) ip vrf exec $vrf_name \ - ${PING} ${sip:+-I $sip} $dip -c 10 -i 0.1 -w $PING_TIMEOUT \ - &> /dev/null + ${PING} ${sip:+-I $sip} $dip -c 10 -i 0.5 -w $ping_timeout \ + &> /dev/null local t1=$(tc_rule_stats_get $dev $pref) local delta=$((t1 - t0)) # Tolerate a couple stray extra packets.