From patchwork Thu Nov 16 04:27:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838408 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="vcyjA2YP"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpFQ40ktz9sBZ for ; Thu, 16 Nov 2017 15:30:18 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758985AbdKPEaF (ORCPT ); Wed, 15 Nov 2017 23:30:05 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:44899 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758750AbdKPE3W (ORCPT ); Wed, 15 Nov 2017 23:29:22 -0500 Received: by mail-pg0-f66.google.com with SMTP id 4so10791684pge.1; Wed, 15 Nov 2017 20:29:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=TQYbha2GK805nYlpg+QUnTO+9keCiXmJyIoDsrk9a1c=; b=vcyjA2YP2M70eP6YxQ7QsjOrVBYGC6j1tgxHqKEKsfbfZV8w/G7bajm9BW6c5oTmpr 6iOzAayRXBmmyecWmNV1HnukbiwvB0fvv9wm78RwRLei/vzmI+IN3fXOsi7e0DQzNKat +H2h5Yw4few6UiEzopTnFmAVKYjz82nFpIdSJct7O/ZoPozojB48iquK2YIS5N1Yqq8r xitt7fu4cJFNnH199UJsCxujCVxiVzHY160adPfKNAQUr5R2aQncDy5pxcybTJoD+bBR 5N/2GCzcpX255HYtyOzD3VYPofSroTogy2EsPK4r/KWGbdSK7N5Ihouc5Su4g/inhUfN nNZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=TQYbha2GK805nYlpg+QUnTO+9keCiXmJyIoDsrk9a1c=; b=lxRcGq2dS8ESuNY5M2U/PEibmHePtIr8jcVkN2AgiehFYefOhb6T9ZLN+QVmUdvqgl ye6UZxIuTO4tT+RlSfxlwpcj6ZPX/SpukT1fL/agMswfWKNXHkAzK0ZholsYT+U6gS0d yd14JbnJvSX4k0Sc2CJQP7cN3kPpz+S0f0H/QNhLT4Kd9sMsQjRXnAHd5LcptiAg51jk vd/rHWgnl/gk7nhgC4uQKp73ajC42SsKLcx9qsghYdENMxaJFtQN5FWU+vWgsn8BdwWi ZUwysgHi+ZUETC/ygn5LWPuDEPbyQG+wCeXo7LI16ZqCjx57FXLgWmlGeRHVWOL4Fuda q1QQ== X-Gm-Message-State: AJaThX7GuYfaCOzfZAukGNMrg1SgVtwg1aP2SglHxsvVWUeFm2jf5RAh 2hrrgg7DxcGKAcYHKm8zzPo= X-Google-Smtp-Source: AGs4zMYOsPWBS/yXTF+SPMPe8yleKzoF++2Bd364MVD2X/eG1Bz8PiumFpT0keoKG+ycveSrtIoaEQ== X-Received: by 10.99.97.200 with SMTP id v191mr405293pgb.300.1510806561558; Wed, 15 Nov 2017 20:29:21 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:21 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 11/12] isdn: hisax: Fix pnp_irq's error checking for setup_sedlbauer_isapnp Date: Thu, 16 Nov 2017 09:57:28 +0530 Message-Id: <35eb61ef566cb62e6ca555f5167c0bf3655c9eed.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/sedlbauer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/sedlbauer.c b/drivers/isdn/hisax/sedlbauer.c index f16a47b..c0b97b8 100644 --- a/drivers/isdn/hisax/sedlbauer.c +++ b/drivers/isdn/hisax/sedlbauer.c @@ -558,7 +558,7 @@ static int setup_sedlbauer_isapnp(struct IsdnCard *card, int *bytecnt) card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "Sedlbauer PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d);