From patchwork Thu Sep 28 09:34:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amine Kherbouche X-Patchwork-Id: 819464 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=6wind-com.20150623.gappssmtp.com header.i=@6wind-com.20150623.gappssmtp.com header.b="iB/qvOhJ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3y2qKK1SMQz9t3C for ; Thu, 28 Sep 2017 19:34:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752552AbdI1Jen (ORCPT ); Thu, 28 Sep 2017 05:34:43 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:51583 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752432AbdI1Jel (ORCPT ); Thu, 28 Sep 2017 05:34:41 -0400 Received: by mail-wm0-f49.google.com with SMTP id i131so982694wma.0 for ; Thu, 28 Sep 2017 02:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MMjpiUKasFT5R+LmSsV8Y/4dolM4+yn6J64obJjHgus=; b=iB/qvOhJ51qawTYFWAOpVc1tol61LxoyTLy+Lc+kehpc/FLF2dzzSKbW7grYYOFEFn RO7YXMq6A/7Lnj6ggW+tRcWQQY7PU1rdv39RysnBgFr/MUV7rY0A5EJm7Z+xYIKhVNl8 qI96e8X1y4jnrrNHhtKN+z5lvpXxXyGC0+4VJEAzIYAwRMDd9ChUmJQVVRBGUw/de2K5 SjtI+MkKIAVeFsBGrFGD7GNkO+XIsZu9ctij6HIXON//D0Zm1kF+BdcmmjZ19NAxunMg BER9dKzuHT/LFVJd+fKSf44EVJUpMt7ZQqOzA4+9qndWj8wgBZqWxZKbP8Jysoe6Uq0u EsBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MMjpiUKasFT5R+LmSsV8Y/4dolM4+yn6J64obJjHgus=; b=PNyzCpprDqAqB7lijcN9V7hFwATwEtoiCMxRFxlPISr6nfTiAVgRfa92ardfIATdr7 828FGGsi/33bYqF+QihDR3qkO7F7EJoae1VOnAomor5mkyPs8lm56kpcoMUURUS/o4hG VkBOLPOfKb8VWILUBJvrqH04MYIaQxr3AwErImvX8nz1O+a6nNUEX4G3+EBrIgGXI3M8 VPI6M86njuuQ0TNVV/lOzI8nqt9X0I+IOmQi0SLbGO8m03T/ehbm8HIgYYdtqV8rsa87 rAwgRe14D5AsGfTLp8cr73ksSOVLazO3CrzkzRDKgauqhZXBYya7j1dSMeHsO2b6hdIm Ubsw== X-Gm-Message-State: AHPjjUguf7S2XnZTqDmWzd6e5j4ViaIkAX3Ut/t34rNSFcyXZ0Kvom1s w8Pu59LeU5WBNp+DC077XLBffHRu X-Google-Smtp-Source: AOwi7QCz1IMnZb6PxWMtyzTHICcHTJvc/kIdBCa605VZPfDwgq1NU/lrziAyDXEPuIDt1qEqABoFZw== X-Received: by 10.80.244.11 with SMTP id r11mr5150776edm.26.1506591280124; Thu, 28 Sep 2017 02:34:40 -0700 (PDT) Received: from griffon.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h56sm1453908ede.15.2017.09.28.02.34.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 28 Sep 2017 02:34:39 -0700 (PDT) From: Amine Kherbouche To: netdev@vger.kernel.org, xeb@mail.ru, roopa@cumulusnetworks.com Cc: amine.kherbouche@6wind.com, equinox@diac24.net Subject: [PATCH v4 2/2] ip_tunnel: add mpls over gre encapsulation Date: Thu, 28 Sep 2017 11:34:20 +0200 Message-Id: <2e611d0f6e0c39ff54bfe464cdf9cf6eeb7843e1.1506590878.git.amine.kherbouche@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This commit introduces the MPLSoGRE support (RFC 4023), using ip tunnel API. Encap: - Add a new iptunnel type mpls. - Share tx path: gre type mpls loaded from skb->protocol. Decap: - pull gre hdr and call mpls_forward(). Signed-off-by: Amine Kherbouche Acked-by: Roopa Prabhu --- include/net/gre.h | 1 + include/uapi/linux/if_tunnel.h | 1 + net/ipv4/gre_demux.c | 27 +++++++++++++++++++++++++++ net/ipv4/ip_gre.c | 3 +++ net/ipv6/ip6_gre.c | 3 +++ net/mpls/af_mpls.c | 36 ++++++++++++++++++++++++++++++++++++ 6 files changed, 71 insertions(+) diff --git a/include/net/gre.h b/include/net/gre.h index d25d836..aa3c4d3 100644 --- a/include/net/gre.h +++ b/include/net/gre.h @@ -35,6 +35,7 @@ struct net_device *gretap_fb_dev_create(struct net *net, const char *name, u8 name_assign_type); int gre_parse_header(struct sk_buff *skb, struct tnl_ptk_info *tpi, bool *csum_err, __be16 proto, int nhs); +int mpls_gre_rcv(struct sk_buff *skb, int gre_hdr_len); static inline int gre_calc_hlen(__be16 o_flags) { diff --git a/include/uapi/linux/if_tunnel.h b/include/uapi/linux/if_tunnel.h index 2e52088..a2f48c0 100644 --- a/include/uapi/linux/if_tunnel.h +++ b/include/uapi/linux/if_tunnel.h @@ -84,6 +84,7 @@ enum tunnel_encap_types { TUNNEL_ENCAP_NONE, TUNNEL_ENCAP_FOU, TUNNEL_ENCAP_GUE, + TUNNEL_ENCAP_MPLS, }; #define TUNNEL_ENCAP_FLAG_CSUM (1<<0) diff --git a/net/ipv4/gre_demux.c b/net/ipv4/gre_demux.c index b798862..40484a3 100644 --- a/net/ipv4/gre_demux.c +++ b/net/ipv4/gre_demux.c @@ -23,6 +23,9 @@ #include #include #include +#if IS_ENABLED(CONFIG_MPLS) +#include +#endif #include #include @@ -122,6 +125,30 @@ int gre_parse_header(struct sk_buff *skb, struct tnl_ptk_info *tpi, } EXPORT_SYMBOL(gre_parse_header); +#if IS_ENABLED(CONFIG_MPLS) +int mpls_gre_rcv(struct sk_buff *skb, int gre_hdr_len) +{ + if (unlikely(!pskb_may_pull(skb, gre_hdr_len))) + goto drop; + + /* Pop GRE hdr and reset the skb */ + skb_pull(skb, gre_hdr_len); + skb_reset_network_header(skb); + + return mpls_forward(skb, skb->dev, NULL, NULL); +drop: + kfree_skb(skb); + return NET_RX_DROP; +} +#else +int mpls_gre_rcv(struct sk_buff *skb, int gre_hdr_len) +{ + kfree_skb(skb); + return NET_RX_DROP; +} +#endif +EXPORT_SYMBOL(mpls_gre_rcv); + static int gre_rcv(struct sk_buff *skb) { const struct gre_protocol *proto; diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index 9cee986..7a50e4f 100644 --- a/net/ipv4/ip_gre.c +++ b/net/ipv4/ip_gre.c @@ -412,6 +412,9 @@ static int gre_rcv(struct sk_buff *skb) return 0; } + if (unlikely(tpi.proto == htons(ETH_P_MPLS_UC))) + return mpls_gre_rcv(skb, hdr_len); + if (ipgre_rcv(skb, &tpi, hdr_len) == PACKET_RCVD) return 0; diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index c82d41e..440efb1 100644 --- a/net/ipv6/ip6_gre.c +++ b/net/ipv6/ip6_gre.c @@ -476,6 +476,9 @@ static int gre_rcv(struct sk_buff *skb) if (hdr_len < 0) goto drop; + if (unlikely(tpi.proto == htons(ETH_P_MPLS_UC))) + return mpls_gre_rcv(skb, hdr_len); + if (iptunnel_pull_header(skb, hdr_len, tpi.proto, false)) goto drop; diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index 36ea2ad..4274243 100644 --- a/net/mpls/af_mpls.c +++ b/net/mpls/af_mpls.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #if IS_ENABLED(CONFIG_IPV6) #include @@ -39,6 +40,36 @@ static int one = 1; static int label_limit = (1 << 20) - 1; static int ttl_max = 255; +#if IS_ENABLED(CONFIG_NET_IP_TUNNEL) +size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e) +{ + return sizeof(struct mpls_shim_hdr); +} + +static const struct ip_tunnel_encap_ops mpls_iptun_ops = { + .encap_hlen = ipgre_mpls_encap_hlen, +}; + +static int ipgre_tunnel_encap_add_mpls_ops(void) +{ + return ip_tunnel_encap_add_ops(&mpls_iptun_ops, TUNNEL_ENCAP_MPLS); +} + +static void ipgre_tunnel_encap_del_mpls_ops(void) +{ + ip_tunnel_encap_del_ops(&mpls_iptun_ops, TUNNEL_ENCAP_MPLS); +} +#else +static int ipgre_tunnel_encap_add_mpls_ops(void) +{ + return 0; +} + +static void ipgre_tunnel_encap_del_mpls_ops(void) +{ +} +#endif + static void rtmsg_lfib(int event, u32 label, struct mpls_route *rt, struct nlmsghdr *nlh, struct net *net, u32 portid, unsigned int nlm_flags); @@ -2486,6 +2517,10 @@ static int __init mpls_init(void) 0); rtnl_register(PF_MPLS, RTM_GETNETCONF, mpls_netconf_get_devconf, mpls_netconf_dump_devconf, 0); + err = ipgre_tunnel_encap_add_mpls_ops(); + if (err) + pr_err("Can't add mpls over gre tunnel ops\n"); + err = 0; out: return err; @@ -2503,6 +2538,7 @@ static void __exit mpls_exit(void) dev_remove_pack(&mpls_packet_type); unregister_netdevice_notifier(&mpls_dev_notifier); unregister_pernet_subsys(&mpls_net_ops); + ipgre_tunnel_encap_del_mpls_ops(); } module_exit(mpls_exit);