diff mbox series

net: drop_monitor: Use kstrdup

Message ID 2dd59a9ea0ed9029caf1b91fb6758ecc7f1dd695.camel@perches.com
State Accepted
Delegated to: David Miller
Headers show
Series net: drop_monitor: Use kstrdup | expand

Commit Message

Joe Perches Jan. 28, 2020, 7:02 p.m. UTC 
Convert the equivalent but rather odd uses of kmemdup with
__GFP_ZERO to the more common kstrdup and avoid unnecessary
zeroing of copied over memory.

Signed-off-by: Joe Perches <joe@perches.com>
---
 net/core/drop_monitor.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

David Miller Jan. 30, 2020, 9:03 a.m. UTC | #1 
From: Joe Perches <joe@perches.com>
Date: Tue, 28 Jan 2020 11:02:50 -0800

> Convert the equivalent but rather odd uses of kmemdup with
> __GFP_ZERO to the more common kstrdup and avoid unnecessary
> zeroing of copied over memory.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Applied.
diff mbox series

Patch

diff --git a/net/core/drop_monitor.c b/net/core/drop_monitor.c
index 536e032..ea46fc 100644
--- a/net/core/drop_monitor.c
+++ b/net/core/drop_monitor.c
@@ -802,16 +802,12 @@  net_dm_hw_metadata_clone(const struct net_dm_hw_metadata *hw_metadata)
 	if (!n_hw_metadata)
 		return NULL;
 
-	trap_group_name = kmemdup(hw_metadata->trap_group_name,
-				  strlen(hw_metadata->trap_group_name) + 1,
-				  GFP_ATOMIC | __GFP_ZERO);
+	trap_group_name = kstrdup(hw_metadata->trap_group_name, GFP_ATOMIC);
 	if (!trap_group_name)
 		goto free_hw_metadata;
 	n_hw_metadata->trap_group_name = trap_group_name;
 
-	trap_name = kmemdup(hw_metadata->trap_name,
-			    strlen(hw_metadata->trap_name) + 1,
-			    GFP_ATOMIC | __GFP_ZERO);
+	trap_name = kstrdup(hw_metadata->trap_name, GFP_ATOMIC);
 	if (!trap_name)
 		goto free_trap_group;
 	n_hw_metadata->trap_name = trap_name;