From patchwork Mon Jul 13 12:15:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Upadhyay X-Patchwork-Id: 1327917 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=AKk8DOTp; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B52fN6ncBz9sRN for ; Mon, 13 Jul 2020 22:15:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729735AbgGMMPV (ORCPT ); Mon, 13 Jul 2020 08:15:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729143AbgGMMPU (ORCPT ); Mon, 13 Jul 2020 08:15:20 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1164DC061755; Mon, 13 Jul 2020 05:15:20 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id w2so5932178pgg.10; Mon, 13 Jul 2020 05:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CngMTDKicRpGsYdV84WEl9k2HNLxAMPDNQJc4li0NJg=; b=AKk8DOTp4rMxlJ8l4EPNhHU9SB8X1hd/H6jmMzRGlZuExBZ4jFqyrebmjVsUjbgI42 fmy1YojOiOrzkQg2zhMnVYY9/sWERz9dqP4hZGPTmch0SyFbkQEKARm5Uabq3WDSaaUc bWb9ctloxEVOL83jY5b7GgpmtUanndBVO6qK0oFcZbaheYe/J+6UOWZKDsaNwrjVLjWv ncJj5KQaD5LknFiiCSgIWeiTfOe81ahB6XdxCf/+6XR5JvgWUHQQZDqhbhE0/Rev+mtd QoNXmhIqcV7uPND8T/M5bryq4CBi7R4lCVsofBVvrG3aRiAIhoTAbpH4phgaMIDPHMwT ZXWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CngMTDKicRpGsYdV84WEl9k2HNLxAMPDNQJc4li0NJg=; b=A8xVhjUyfgyyU1nEooFhxNPM5f+YhRxm470h4WVYU/gUiY0HA1P4LWUtDWz0YJ2L/S kr85c3Hyq9UdB4Z18qweCvfKzKNF/zGTOWilhyzceMSNE2Zj1WhdUynffBLi5KjSWbh8 XnacmEr2ulc1ZSgRr9F8/DrtRstjTI3FzXVK9Nq+q79dLVj2I2aYrbkObaStBMAcdFMo wWK4YE0jkbc2ZfaNW78wnee5MujJL6k5WqQwme91CUG0Z6MmJH2piKKVbGMAHbEQmBnM Gj9V1+GKh6fqWmZOocS5ItJCszffLsnEzkRABZosg5tfaH972t7tyZ6JZPk/IIk3K9PK 9cXg== X-Gm-Message-State: AOAM531D27z/V58Q0lX/1HSHCao6RF7ScfuYjYg6EwiVY9j3iu27kd5q 9KrROIekxasnTP49WAuHbm/DRlLmdEFCZQ== X-Google-Smtp-Source: ABdhPJzL4TVE2ZmLdK+X8Ime38AucFBJP/ru8QjY494q9pZhTWeJLxmhEama436Fg3gRphnMt2sahg== X-Received: by 2002:a63:e80e:: with SMTP id s14mr63928961pgh.32.1594642519579; Mon, 13 Jul 2020 05:15:19 -0700 (PDT) Received: from blackclown ([103.88.82.220]) by smtp.gmail.com with ESMTPSA id o8sm13164541pgb.23.2020.07.13.05.15.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Jul 2020 05:15:18 -0700 (PDT) Date: Mon, 13 Jul 2020 17:45:05 +0530 From: Suraj Upadhyay To: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] staging: qlge: qlge.h: Function definition arguments should have names. Message-ID: <2d788cffeec2dad9ce9562c15a69d8b63ed0b21f.1594642213.git.usuraj35@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Issue found with checkpatch.pl Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index 05e4f47442a3..48bc494028ce 100644 --- a/drivers/staging/qlge/qlge.h +++ b/drivers/staging/qlge/qlge.h @@ -2057,8 +2057,8 @@ enum { }; struct nic_operations { - int (*get_flash)(struct ql_adapter *); - int (*port_initialize)(struct ql_adapter *); + int (*get_flash)(struct ql_adapter *qdev); + int (*port_initialize)(struct ql_adapter *qdev); }; /* @@ -2275,7 +2275,7 @@ int ql_mb_set_port_cfg(struct ql_adapter *qdev); int ql_wait_fifo_empty(struct ql_adapter *qdev); void ql_get_dump(struct ql_adapter *qdev, void *buff); netdev_tx_t ql_lb_send(struct sk_buff *skb, struct net_device *ndev); -void ql_check_lb_frame(struct ql_adapter *, struct sk_buff *); +void ql_check_lb_frame(struct ql_adapter *qdev, struct sk_buff *skb); int ql_own_firmware(struct ql_adapter *qdev); int ql_clean_lb_rx_ring(struct rx_ring *rx_ring, int budget);