From patchwork Thu Nov 16 04:27:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838404 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="C/g6d3/w"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpDY56T6z9s7G for ; Thu, 16 Nov 2017 15:29:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932744AbdKPE3b (ORCPT ); Wed, 15 Nov 2017 23:29:31 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:50984 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbdKPE3D (ORCPT ); Wed, 15 Nov 2017 23:29:03 -0500 Received: by mail-pg0-f67.google.com with SMTP id u3so4543535pgn.7; Wed, 15 Nov 2017 20:29:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=WMPKL2IxkQOOxMl/iLySB4uO0jSLNOpPSROH7sCkoWg=; b=C/g6d3/wbmH5eqrz5oVB+Zb+4Nu7cA7IZTN2TPBQTL17rzS3VZC36+YA95RHpayC2O DmZjRqg1dejgiJqGRYWimAGFAvnZILctq1kwWL6NPRBxNQMPPS6FyhM4Nf/zs2lW3Im1 56bMWzfOMKMhOPx0fF0NKUmG3yqvoHmdtC7S1JJ+xmvYZyoc5V+v6m4sDAsBto8SgT30 A2WbVL7zWKQKWelOfDRShsDFUWLjOjiRsM9w+TV2FaKrbJB8l0aqOQU4tZU7T1K1hOx4 KeohkJI0hbW/NjZ0ncpg7wnfpNkne5usXDqYFHc6AjiAnPZ/Vkx4h7V8hCbMFEzlAP76 9RUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=WMPKL2IxkQOOxMl/iLySB4uO0jSLNOpPSROH7sCkoWg=; b=Dvi0pGsSHfxiCeHeDbNpWnZ9L5eLNYFAmMcRVlMAxJv8/2r8e683JQlkvOScbR/emx Hm+qSBMOhZP3qa3NpNNAbYzsb3iluqek743UtxgagIB4wZTf2cx9gpTbiF3T1j/eP1T6 mBBANcZx8LoOmWlGZSeZ+D6XwsQr4x8FueicW2Jsf5C4AvXQtt83ZwT1KNej5eeOKShj lEy9CX0kgX/BjLYpqToWC/2qWKsej/ahNUneF6pVXTKSoCHMgX61gVmeDMiHI6qkWWN8 IZ7y8L2nOvrhh3nSh+k48COYnkllg1G2dndtFOSA8mRUfs5F0c2M/8NyCt1E6+RdcmFZ OIFA== X-Gm-Message-State: AJaThX4EgFev9qj80gQKI5vDZ9APvGCJHbR5uZSel/8+gCyazWb8VC+I nZru78mFbOoit6EGxhljwYQ= X-Google-Smtp-Source: AGs4zMaIFOe8fK/mX29rJ4dY4iGtIWnzrdYbh6JuDF0G+/xoU0JzMIGp3b8ss7WGW2P2ITr2iPko0A== X-Received: by 10.101.80.200 with SMTP id s8mr415356pgp.23.1510806542389; Wed, 15 Nov 2017 20:29:02 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.28.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:01 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 04/12] isdn: hisax: Fix pnp_irq's error checking for setup_elsa_isapnp Date: Thu, 16 Nov 2017 09:57:21 +0530 Message-Id: <2d169e32d2abac9872ad4cbb172e1fb3398db8df.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/elsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/elsa.c b/drivers/isdn/hisax/elsa.c index 03bc5d5..f8dcac8 100644 --- a/drivers/isdn/hisax/elsa.c +++ b/drivers/isdn/hisax/elsa.c @@ -945,7 +945,7 @@ static int setup_elsa_isapnp(struct IsdnCard *card) card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "Elsa PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d);