From patchwork Fri Jan 9 18:10:38 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Fleming X-Patchwork-Id: 17564 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 2EF2E4750F for ; Sat, 10 Jan 2009 05:10:45 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752958AbZAISKl (ORCPT ); Fri, 9 Jan 2009 13:10:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752882AbZAISKl (ORCPT ); Fri, 9 Jan 2009 13:10:41 -0500 Received: from wf-out-1314.google.com ([209.85.200.169]:62309 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751988AbZAISKk (ORCPT ); Fri, 9 Jan 2009 13:10:40 -0500 Received: by wf-out-1314.google.com with SMTP id 27so9965770wfd.4 for ; Fri, 09 Jan 2009 10:10:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=8+PQ+Qg/mQbKz1AghKF2dnA4kA7BnUAu/ZAYvVZkTSc=; b=DIj0ksUqp93z5BqvS2BY1no8KDuDf2kmHCdX+xCHxEds3s4yXr461hVa7pIMLpqitX /TlSCYexA9Awyx8Hvw8QNlr1wr3RbSFc1TauPaGEYnrwpcxVwYF33mdoExUjTLd+cB5q 88RaePIucAaKfUhiPpnUHo/NkrAAvaXJfSE3Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=h/mfN7ZT3BZLiKBGoccsoinUEmeIXpt0j471/Toqiq5+6Mv0xJ7K2GYuhKpt+oZNIO lVvHntX+YLN/oaEQzKpqomXmhDvJjmih8XoCMzcIyvejRUGwf5SIOosEAnHZ9ZG/YlnB +bBY+T9xIxxkILD7cAh1Ulh4UUMlFtjF0K9Ls= Received: by 10.142.12.14 with SMTP id 14mr10826632wfl.203.1231524638970; Fri, 09 Jan 2009 10:10:38 -0800 (PST) Received: by 10.143.35.13 with HTTP; Fri, 9 Jan 2009 10:10:38 -0800 (PST) Message-ID: <2acbd3e40901091010r38d221b5nc2b2c98b589e55cb@mail.gmail.com> Date: Fri, 9 Jan 2009 12:10:38 -0600 From: "Andy Fleming" To: "Dave Jones" Subject: Re: 2.6.28-git1 gianfar compile failure (ppc). Cc: "Dai Haruki" , "Andy Fleming" , netdev@vger.kernel.org In-Reply-To: <20081229054026.GA14962@redhat.com> MIME-Version: 1.0 Content-Disposition: inline References: <20081229054026.GA14962@redhat.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Dec 28, 2008 at 11:41 PM, Dave Jones wrote: > ERROR: "cacheable_memzero" [drivers/net/gianfar_driver.ko] undefined! > > Introduced in a22823e72a4821ce1d4a248fbd8f5a81795af339 > > I guess that needs exporting for when gianfar is modular, but I've no > idea how to export things from powerpc assembly. > > Dave > This patch which was posted to linuxppc-dev should fix your bug: From: Kumar Gala Date: Tue, Jan 6, 2009 at 11:00 PM Subject: [PATCH] powerpc: Export cacheable_memzero as its now used in a driver To: linuxppc-dev@ozlabs.org The Freescale PowerPC specific gianfar driver (gig-e) uses cacheable_memzero for performance reasons we need to export the symbol to allow the driver to be built as a module. Signed-off-by: Kumar Gala --- arch/powerpc/kernel/ppc_ksyms.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/powerpc/kernel/ppc_ksyms.c b/arch/powerpc/kernel/ppc_ksyms.c index dcec132..c8b27bb 100644 --- a/arch/powerpc/kernel/ppc_ksyms.c +++ b/arch/powerpc/kernel/ppc_ksyms.c @@ -165,6 +165,7 @@ EXPORT_SYMBOL(timer_interrupt); EXPORT_SYMBOL(irq_desc); EXPORT_SYMBOL(tb_ticks_per_jiffy); EXPORT_SYMBOL(cacheable_memcpy); +EXPORT_SYMBOL(cacheable_memzero); #endif #ifdef CONFIG_PPC32