From patchwork Tue Nov 23 03:31:12 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Skidmore, Donald C" X-Patchwork-Id: 72623 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7E4AEB70E7 for ; Tue, 23 Nov 2010 14:31:21 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750917Ab0KWDbO (ORCPT ); Mon, 22 Nov 2010 22:31:14 -0500 Received: from mga11.intel.com ([192.55.52.93]:12115 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756Ab0KWDbO convert rfc822-to-8bit (ORCPT ); Mon, 22 Nov 2010 22:31:14 -0500 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 22 Nov 2010 19:31:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,240,1288594800"; d="scan'208";a="629392729" Received: from orsmsx602.amr.corp.intel.com ([10.22.226.211]) by fmsmga002.fm.intel.com with ESMTP; 22 Nov 2010 19:31:13 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.226.10) by orsmsx602.amr.corp.intel.com (10.22.226.211) with Microsoft SMTP Server (TLS) id 8.2.254.0; Mon, 22 Nov 2010 19:31:13 -0800 Received: from orsmsx509.amr.corp.intel.com ([10.22.226.43]) by orsmsx605.amr.corp.intel.com ([10.22.226.10]) with mapi; Mon, 22 Nov 2010 19:31:13 -0800 From: "Skidmore, Donald C" To: Yinghai Lu , "Kirsher, Jeffrey T" CC: "Brandeburg, Jesse" , David Miller , NetDev Date: Mon, 22 Nov 2010 19:31:12 -0800 Subject: RE: ixgbe dump Thread-Topic: ixgbe dump Thread-Index: AcuKnOrcp8DATQKBQ4y6as9ho23jgQAIXMjA Message-ID: <29F4ED941D916B48B88B4D2A4F3D1B9C01CC08FBCF@orsmsx509.amr.corp.intel.com> References: <4CE47FA6.8050600@kernel.org> <29F4ED941D916B48B88B4D2A4F3D1B9C01CBFC68C5@orsmsx509.amr.corp.intel.com> <1290468133.2603.2.camel@jtkirshe-MOBL1> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Yinghai, I was hoping we could have had this patch pushed upstream sooner, but we have quite a few in our internal queue right now. If this doesn't solve your issue please let me know. Thanks, -Don Skidmore After freeing the rings we were not zeroing out the ring count values. This patch now clears these counts correctly. Reported-by: Yinghai Lu Signed-off-by: Don Skidmore --- drivers/net/ixgbe/ixgbe_main.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) >-----Original Message----- >From: yhlu.kernel@gmail.com [mailto:yhlu.kernel@gmail.com] On Behalf Of >Yinghai Lu >Sent: Monday, November 22, 2010 3:28 PM >To: Kirsher, Jeffrey T >Cc: Skidmore, Donald C; Brandeburg, Jesse; David Miller; NetDev >Subject: Re: ixgbe dump > >On Mon, Nov 22, 2010 at 3:22 PM, Jeff Kirsher > wrote: >> >> It is not posted yet. Don got the patch to our testers and they are >> doing a quick validation on the patch before I post it to netdev. >> >> I can send you the patch, so that you can assist in letting us know if >> it resolves the issue. > >sure. please send that to me. > >Thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index fbad4d8..eee0b29 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c @@ -4771,6 +4771,9 @@ void ixgbe_clear_interrupt_scheme(struct ixgbe_adapter *adapter) adapter->rx_ring[i] = NULL; } + adapter->num_tx_queues = 0; + adapter->num_rx_queues = 0; + ixgbe_free_q_vectors(adapter); ixgbe_reset_interrupt_capability(adapter); }