| Message ID | 29F4ED941D916B48B88B4D2A4F3D1B9C01CC08FBCF@orsmsx509.amr.corp.intel.com |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, Nov 22, 2010 at 7:31 PM, Skidmore, Donald C <donald.c.skidmore@intel.com> wrote: > > Hi Yinghai, > > I was hoping we could have had this patch pushed upstream sooner, but we have quite a few in our internal queue right now. > > If this doesn't solve your issue please let me know. > > Thanks, > -Don Skidmore <donald.c.skidmore@intel.com> > > > > > After freeing the rings we were not zeroing out the ring count values. > This patch now clears these counts correctly. > > Reported-by: Yinghai Lu <yinghai@kernel.org> > Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com> > --- > > drivers/net/ixgbe/ixgbe_main.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c > index fbad4d8..eee0b29 100644 > --- a/drivers/net/ixgbe/ixgbe_main.c > +++ b/drivers/net/ixgbe/ixgbe_main.c > @@ -4771,6 +4771,9 @@ void ixgbe_clear_interrupt_scheme(struct ixgbe_adapter *adapter) > adapter->rx_ring[i] = NULL; > } > > + adapter->num_tx_queues = 0; > + adapter->num_rx_queues = 0; > + > ixgbe_free_q_vectors(adapter); > ixgbe_reset_interrupt_capability(adapter); > } OK, that fix the problem. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>-----Original Message----- >From: yhlu.kernel@gmail.com [mailto:yhlu.kernel@gmail.com] On Behalf Of >Yinghai Lu >Sent: Monday, November 22, 2010 8:16 PM >To: Skidmore, Donald C >Cc: Kirsher, Jeffrey T; Brandeburg, Jesse; David Miller; NetDev >Subject: Re: ixgbe dump > >On Mon, Nov 22, 2010 at 7:31 PM, Skidmore, Donald C ><donald.c.skidmore@intel.com> wrote: >> >> Hi Yinghai, >> >> I was hoping we could have had this patch pushed upstream sooner, but we >have quite a few in our internal queue right now. >> >> If this doesn't solve your issue please let me know. >> >> Thanks, >> -Don Skidmore <donald.c.skidmore@intel.com> >> >> >> >> >> After freeing the rings we were not zeroing out the ring count values. >> This patch now clears these counts correctly. >> >> Reported-by: Yinghai Lu <yinghai@kernel.org> >> Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com> >> --- >> >> drivers/net/ixgbe/ixgbe_main.c | 3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/ixgbe/ixgbe_main.c >b/drivers/net/ixgbe/ixgbe_main.c >> index fbad4d8..eee0b29 100644 >> --- a/drivers/net/ixgbe/ixgbe_main.c >> +++ b/drivers/net/ixgbe/ixgbe_main.c >> @@ -4771,6 +4771,9 @@ void ixgbe_clear_interrupt_scheme(struct >ixgbe_adapter *adapter) >> adapter->rx_ring[i] = NULL; >> } >> >> + adapter->num_tx_queues = 0; >> + adapter->num_rx_queues = 0; >> + >> ixgbe_free_q_vectors(adapter); >> ixgbe_reset_interrupt_capability(adapter); >> } > >OK, that fix the problem. > >Thanks > >Yinghai That great to hear. Hopefully we will be able to get the patch submitted soon. Thanks, -Don -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index fbad4d8..eee0b29 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c @@ -4771,6 +4771,9 @@ void ixgbe_clear_interrupt_scheme(struct ixgbe_adapter *adapter) adapter->rx_ring[i] = NULL; } + adapter->num_tx_queues = 0; + adapter->num_rx_queues = 0; + ixgbe_free_q_vectors(adapter); ixgbe_reset_interrupt_capability(adapter); }