Message ID | 271e26e7350f418bad08761cab439005@Mail06.usask.ca |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
On Mon, Sep 26, 2016 at 03:56:59PM -0600, Chris Roth wrote: > I'm not sure what I'm doing wrong: > > I'm trying to get the from statement to read original author (Allan > Chou) first, and then me (Chris Roth) second. I've used the following > two commands: > > git format-patch -o /tmp/ --subject-prefix="PATCH v2" --from="Allan > Chou <allan@asix.com.tw>" HEAD^ > > and > > git send-email --to linux-usb@vger.kernel.org --to > netdev@vger.kernel.org --to linux-kernel@vger.kernel.org --from="Allan > Chou <allan@asix.com.tw>" > /tmp/0001-Net-Driver-Add-Cypress-GX3-VID-04b4-PID-3610.patch > > I thought that adding the --from portions to the git format-patch and > git send-email commands would force the addition of Allan to the top > of the patch, but it hasn't. Can anyone tell me specifically how I > need to change these commands in order to get the desired result? Then > I'll submit a PATCH v3. Take the patch that you have, hand-edit it with your favorite editor to have the correct headers and signed-off-by and other fields, and then use git send-email without the --from line, and you should be fine. thanks, greg k-h
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index e6338c1..8a6675d 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1656,6 +1656,19 @@ static const struct driver_info ax88178a_info = { .tx_fixup = ax88179_tx_fixup, }; +static const struct driver_info cypress_GX3_info = { + .description = "Cypress GX3 SuperSpeed to Gigabit Ethernet Controller", + .bind = ax88179_bind, + .unbind = ax88179_unbind, + .status = ax88179_status, + .link_reset = ax88179_link_reset, + .reset = ax88179_reset, + .stop = ax88179_stop, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .rx_fixup = ax88179_rx_fixup, + .tx_fixup = ax88179_tx_fixup, +}; + static const struct driver_info dlink_dub1312_info = { .description = "D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter", .bind = ax88179_bind, @@ -1718,6 +1731,10 @@ static const struct usb_device_id products[] = { USB_DEVICE(0x0b95, 0x178a), .driver_info = (unsigned long)&ax88178a_info, }, { + /* Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller */ + USB_DEVICE(0x04b4, 0x3610), + .driver_info = (unsigned long)&cypress_GX3_info, +}, { /* D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter */ USB_DEVICE(0x2001, 0x4a00), .driver_info = (unsigned long)&dlink_dub1312_info,