From patchwork Thu Jan 31 22:35:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Machata X-Patchwork-Id: 1034498 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="gLk14Ehd"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43rFRs2TXcz9sDX for ; Fri, 1 Feb 2019 09:35:21 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729392AbfAaWfU (ORCPT ); Thu, 31 Jan 2019 17:35:20 -0500 Received: from mail-eopbgr70075.outbound.protection.outlook.com ([40.107.7.75]:14830 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727471AbfAaWfT (ORCPT ); Thu, 31 Jan 2019 17:35:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=47q/bk+/5ROeBFyAbmhpvI5wb3hghSPnmtSwL7yyYuk=; b=gLk14Ehdl2uQ1k4GuMdRtcg8s8fZIHRzAvjjrLjMhe/dsNIZwYBDF2HGeZxtDna1MOVrdluNkPBerIBKRQdchtaJJ39GyiCTaUvrR5AXflynCvY5Kl01zGcIpKU1gO5nmIx6T8zqTYSopCMx+kwkP1rCFacAu44XyC7Br/YWvLw= Received: from AM6PR05MB4885.eurprd05.prod.outlook.com (20.177.34.225) by AM6PR05MB6470.eurprd05.prod.outlook.com (20.179.7.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1580.17; Thu, 31 Jan 2019 22:35:14 +0000 Received: from AM6PR05MB4885.eurprd05.prod.outlook.com ([fe80::3830:b2de:562:1fe6]) by AM6PR05MB4885.eurprd05.prod.outlook.com ([fe80::3830:b2de:562:1fe6%4]) with mapi id 15.20.1558.025; Thu, 31 Jan 2019 22:35:14 +0000 From: Petr Machata To: "netdev@vger.kernel.org" CC: Ido Schimmel Subject: [PATCH net-next 03/11] selftests: mlxsw: Update ping limits Thread-Topic: [PATCH net-next 03/11] selftests: mlxsw: Update ping limits Thread-Index: AQHUubU7JM9RBNkh10mHeibUjI8O1A== Date: Thu, 31 Jan 2019 22:35:14 +0000 Message-ID: <25f150899413f126a8fab3fb5de80df91a428c8a.1548973731.git.petrm@mellanox.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6PR02CA0035.eurprd02.prod.outlook.com (2603:10a6:20b:6e::48) To AM6PR05MB4885.eurprd05.prod.outlook.com (2603:10a6:20b:b::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=petrm@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [78.45.160.211] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR05MB6470; 6:33AUhL5mqPj+8AR4EE47JlAJ10un4FFnL9rqozCtQV4Zk2kdN4nYX4lfoD2TzWglP8D7kAJSnWvPxFH3sWZcL4yhgUR8krg1RaSpQDoE01KDA4+Tbr6R61RgXE0SdRpETPfyiFGt/TXb6xthFPnKDNVVUvSbzwi4U3Nbr7ke833mGri6n5U3tE9XysvjBnS+Vmfov1WcMJ2ZBKNZTSnL1xgakre9YDkSgaMqBRuvMo9kwYCJ4HcxcpwXNqUa03JuL6ovlAjWnvDMgk67zFgoMMVQVREBCb4dD2JxMI95KToF2K4RwwIv+BSz6qB4QigvY7AmmdifRKj1+tKC/a2X/o/oKv+eTUFm4BBMIwfPleJa8wrH3ogF9jDRfR2A4QuUvEwhTQ0E/piJtDiLzFQoG/MlVrOpHm1hg32bzvxYRqn5rMQnNP6cHROtJ6z/UNuz/V6MkvZjrAQjH6WVE5rqIg==; 5:mdys24K5RO5Vz7o/W7ousip7s2WMQd/91Wl+7PuSibAbLRw5yy3jfakHVdSuCWYYARk7kcI3FJX1+qzN/h+1CoYqQuB/XLcYzKVvD0bRtai2ZyTegYu99tAnoH9p8AJqgm2MgXvgthswvFYI5MicUt9myBB4YtOzA1U9t08nYz5LgWqGyvjddbR40SznwNwqlVfPtrWZrA2NqHmUPGf3yg==; 7:7Dx02pT9M3gSSeS5xrhLSWxGmgOkVNOjQwdTAP4rLtXSD1r8EN0JX1Hpn9UKc8Z+HwNnqDG4+YfqjyGWsxifd/Xa7mGGksgkkCKhaMiCJXaT0fCACZN2pproYM9o/EcNYM57zV34MgQ8QjU+1IrNKQ== x-ms-office365-filtering-correlation-id: c3092fe1-ee09-42a1-6169-08d687cc5e0b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR05MB6470; x-ms-traffictypediagnostic: AM6PR05MB6470: x-microsoft-antispam-prvs: x-forefront-prvs: 09347618C4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(346002)(376002)(396003)(39860400002)(199004)(189003)(105586002)(99286004)(6436002)(3846002)(7736002)(86362001)(6486002)(76176011)(4326008)(6116002)(305945005)(52116002)(5640700003)(36756003)(316002)(71200400001)(256004)(71190400001)(106356001)(6916009)(25786009)(53936002)(186003)(478600001)(476003)(2616005)(118296001)(26005)(11346002)(66574012)(446003)(2351001)(486006)(6512007)(107886003)(2906002)(81156014)(8936002)(1730700003)(8676002)(14454004)(2501003)(68736007)(66066001)(81166006)(6506007)(386003)(97736004)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB6470; H:AM6PR05MB4885.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: N6YAqBQYWb/EVRMYwTJvBGC7ojquVM4ADx0EIYjcxEnQTQnjpWhGt9B4LGVAXgjBeTsQifBofmlhfRYCuiaFujaIsjWD8nyPWCRypljHz1jXTP4KcYVrt+FEsrWcvNrPccJvRM/O39ecN77iTUh4lFfWmAw+afScdxRBryzcHM8cbMJsJUr/LOtvTgnRpqGCtaNsLdLHawYSrdy0bO9ZwqqrFAjjMngGHrsPF+XbxW83kAmSgFlgikJG+bPBac+Ijr+qeF2M0rLYCBjphCZFv2Q3S0Q+qMslMxCbWyX8N7sFeqXqYe6pMA9zOLP9z2D1RjMQjhoy4Wfed1BAdz9EYyS66A+lIE5RDFYZeOl4LYjgd7kLeqmeIgFZVRBXAyi4eV9BAjk039sfSI6OYRqFfv3Ou0/eqzESctRY0GoiD78= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3092fe1-ee09-42a1-6169-08d687cc5e0b X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2019 22:35:13.9095 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6470 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The current ping intervals are too short for running mirroring tests in simulator. This leads to ping sending a follow-up ping before the reply arrives, thus sending more than the requested 10 ICMP requests. This traffic is seen at the counters, and causes spurious failures. Bump interval and timeout numbers 5x in mirroring tests to address the spurious failures. Signed-off-by: Petr Machata --- tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh | 3 ++- tools/testing/selftests/drivers/net/mlxsw/qos_dscp_router.sh | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh b/tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh index 111baedc5742..40f16f2a3afd 100755 --- a/tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh +++ b/tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh @@ -148,9 +148,10 @@ dscp_ping_test() eval "t0s=($(dscp_fetch_stats $dev_10 10) $(dscp_fetch_stats $dev_20 20))" + local ping_timeout=$((PING_TIMEOUT * 5)) ip vrf exec $vrf_name \ ${PING} -Q $dscp_10 ${sip:+-I $sip} $dip \ - -c 10 -i 0.1 -w $PING_TIMEOUT &> /dev/null + -c 10 -i 0.5 -w $ping_timeout &> /dev/null local -A t1s eval "t1s=($(dscp_fetch_stats $dev_10 10) diff --git a/tools/testing/selftests/drivers/net/mlxsw/qos_dscp_router.sh b/tools/testing/selftests/drivers/net/mlxsw/qos_dscp_router.sh index 6fa717ef91ef..9faf02e32627 100755 --- a/tools/testing/selftests/drivers/net/mlxsw/qos_dscp_router.sh +++ b/tools/testing/selftests/drivers/net/mlxsw/qos_dscp_router.sh @@ -169,9 +169,10 @@ dscp_ping_test() eval "local -A dev1_t0s=($(dscp_fetch_stats $dev1 0))" eval "local -A dev2_t0s=($(dscp_fetch_stats $dev2 0))" + local ping_timeout=$((PING_TIMEOUT * 5)) ip vrf exec $vrf_name \ ${PING} -Q $dscp ${sip:+-I $sip} $dip \ - -c 10 -i 0.1 -w $PING_TIMEOUT &> /dev/null + -c 10 -i 0.5 -w $ping_timeout &> /dev/null eval "local -A dev1_t1s=($(dscp_fetch_stats $dev1 0))" eval "local -A dev2_t1s=($(dscp_fetch_stats $dev2 0))"