From patchwork Fri Aug 28 23:18:34 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jay Vosburgh X-Patchwork-Id: 32482 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id C7E5EB708C for ; Sat, 29 Aug 2009 09:18:43 +1000 (EST) Received: by ozlabs.org (Postfix) id BCF97DDD0C; Sat, 29 Aug 2009 09:18:43 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 503A4DDD0B for ; Sat, 29 Aug 2009 09:18:43 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751125AbZH1XSf (ORCPT ); Fri, 28 Aug 2009 19:18:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750997AbZH1XSf (ORCPT ); Fri, 28 Aug 2009 19:18:35 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:48363 "EHLO e8.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbZH1XSe convert rfc822-to-8bit (ORCPT ); Fri, 28 Aug 2009 19:18:34 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e8.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id n7SNISZ9018410 for ; Fri, 28 Aug 2009 19:18:28 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n7SNIaTZ246234 for ; Fri, 28 Aug 2009 19:18:36 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n7SNIa3t007107 for ; Fri, 28 Aug 2009 19:18:36 -0400 Received: from death.nxdomain.ibm.com (sig-9-65-43-152.mts.ibm.com [9.65.43.152]) by d01av01.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n7SNIYS4007091 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 28 Aug 2009 19:18:35 -0400 Received: from localhost ([127.0.0.1] helo=death.nxdomain.ibm.com) by death.nxdomain.ibm.com with esmtp (Exim 4.69) (envelope-from ) id 1MhAiI-00069Y-P9; Fri, 28 Aug 2009 16:18:34 -0700 From: Jay Vosburgh To: David Miller cc: netdev@vger.kernel.org, nicolas.2p.debian@free.fr Subject: Re: [PATCH REPOST net-next-2.6 3/4] bonding: Fix useless test: int > INT_MAX In-reply-to: <20090828.154911.197007102.davem@davemloft.net> References: <1251497115-16234-2-git-send-email-fubar@us.ibm.com> <1251497115-16234-3-git-send-email-fubar@us.ibm.com> <1251497115-16234-4-git-send-email-fubar@us.ibm.com> <20090828.154911.197007102.davem@davemloft.net> Comments: In-reply-to David Miller message dated "Fri, 28 Aug 2009 15:49:11 -0700." X-Mailer: MH-E 8.0.3; nmh 1.3-RC3; GNU Emacs 22.2.1 MIME-Version: 1.0 Date: Fri, 28 Aug 2009 16:18:34 -0700 Message-ID: <23655.1251501514@death.nxdomain.ibm.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org David Miller wrote: >From: Jay Vosburgh >Date: Fri, 28 Aug 2009 15:05:14 -0700 > >> From: Nicolas de Pesloüan >> >> max_bonds is of type int and cannot be greater than INT_MAX. >> >> Signed-off-by: Nicolas de Pesloüan >> Signed-off-by: Jay Vosburgh > >It seems you use two different encodings here for Nicolas's >last name, and thus the two-dotted 'u' comes out corrupted >in the From: field. > >This causes patchwork to not be able to parse the patch >and thus put it properly into the queue. So all that's >in there are patches #1, #2 and #4. Hmm. Does this one work any better? I just copied the Signed-off-by text into the From: line. -J From: Nicolas de Pesloüan Date: Sat, 22 Aug 2009 14:17:21 +0200 Subject: [PATCH REPOST net-next-2.6 3/4] bonding: Fix useless test: int > INT_MAX MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit max_bonds is of type int and cannot be greater than INT_MAX. Signed-off-by: Nicolas de Pesloüan Signed-off-by: Jay Vosburgh --- drivers/net/bonding/bond_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index ed00ba9..6b9f15b 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -4759,7 +4759,7 @@ static int bond_check_params(struct bond_params *params) params->ad_select = BOND_AD_STABLE; } - if (max_bonds < 0 || max_bonds > INT_MAX) { + if (max_bonds < 0) { pr_warning(DRV_NAME ": Warning: max_bonds (%d) not in range %d-%d, so it " "was reset to BOND_DEFAULT_MAX_BONDS (%d)\n",