From patchwork Thu Nov 12 15:25:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Van Asbroeck X-Patchwork-Id: 1399033 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=W22ZYKa5; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CX55H5snLz9sRR for ; Fri, 13 Nov 2020 02:25:23 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728581AbgKLPZT (ORCPT ); Thu, 12 Nov 2020 10:25:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727822AbgKLPZT (ORCPT ); Thu, 12 Nov 2020 10:25:19 -0500 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F450C0613D1; Thu, 12 Nov 2020 07:25:19 -0800 (PST) Received: by mail-qk1-x744.google.com with SMTP id y197so5541790qkb.7; Thu, 12 Nov 2020 07:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=oF5Wh7P+oRrquR6KUXu2p6XiVm+Wzsg2M5qKrcerhsg=; b=W22ZYKa5nMtAfWIMYxtyvCPp6xl8VWzGp75P8Dql+2AEM8Pl9lKbcFCACooQNpi/rM IPpfSj4REpmeAN8WLpbLWKLENLnSHzmrY2NRYgtuR8aks5JxkBw/AlEbMAo8eS1TStON xMaqfyKWlOksNflTBADnjRxIpl8T0P+Vkbm9kIfuijmx4E35BMZZfUciIVA/VsJ3IrNN 3sQUNtq7HkAa0m4QuxUFqc4crgGbxcQE8WpP5l7ej4C5AehnSYpLxndocZT7ZEAm9cY1 s6MCvKlWWuZhXEsIdopjXVGDBIPouV5l6rRyAwtIs6ASRCQaEOUvB/J7pA4EnWBEw1LF 6Nog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=oF5Wh7P+oRrquR6KUXu2p6XiVm+Wzsg2M5qKrcerhsg=; b=XM1XQvxyH7hezZHvEe+rorLejwTFZ5zPywdBWpuLU7vfD8dDd6RhwpCXqhaLHt43tS TSf4YjTIr/6Y7VVgvYrfEd63SitTtsKZqnDfzhm6+tWC+5UuaJonAiTr8KwqAAEDIXDL VPeFyQ5Xg1oT3hFRO1AB7SrVKsQSaUSTAL0F7d8irx2Y1yZNaeJG0ni7/zzaEa/FLucN nM2yedxtOAwby/McIjKpgCh2CXUglqmSknYVcck+n78m9SZJGfu/ehASvErm6wAE3c97 5ksY//pMesM29Gi7M0kzSeWhkXhCR8hwubYS2zPT32mG4hF1YkAeAZMN9rRx6VbE0koU envQ== X-Gm-Message-State: AOAM5329y3KwBgIEJj3YSVAUoCOwP6oMQKiLBfDdQwuDj32i7qOq8dpp gSkdlvygmlKodIoNxqq6O5Q= X-Google-Smtp-Source: ABdhPJyr2e/npL9QyKK+HcbhXebOEHj/YQj4xW726y5VbBJp5wlj01dho4YN50jezVx1/XO6INPENA== X-Received: by 2002:a37:6fc5:: with SMTP id k188mr223183qkc.317.1605194718178; Thu, 12 Nov 2020 07:25:18 -0800 (PST) Received: from localhost.localdomain ([198.52.185.246]) by smtp.gmail.com with ESMTPSA id h6sm4578150qtm.68.2020.11.12.07.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 07:25:17 -0800 (PST) From: Sven Van Asbroeck X-Google-Original-From: Sven Van Asbroeck To: Jakub Kicinski , Bryan Whitehead , David S Miller Cc: Sven Van Asbroeck , Microchip Linux Driver Support , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v1] lan743x: fix use of uninitialized variable Date: Thu, 12 Nov 2020 10:25:13 -0500 Message-Id: <20201112152513.1941-1-TheSven73@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sven Van Asbroeck When no devicetree is present, the driver will use an uninitialized variable. Fix by initializing this variable. Fixes: 902a66e08cea ("lan743x: correctly handle chips with internal PHY") Reported-by: kernel test robot Signed-off-by: Sven Van Asbroeck --- Tree: git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git # 52755b66ddce To: Jakub Kicinski To: Bryan Whitehead To: "David S. Miller" Cc: Microchip Linux Driver Support Cc: Andrew Lunn Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org drivers/net/ethernet/microchip/lan743x_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c index 54d721ef3084..0c9b938ee0ea 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -1014,8 +1014,8 @@ static void lan743x_phy_close(struct lan743x_adapter *adapter) static int lan743x_phy_open(struct lan743x_adapter *adapter) { struct lan743x_phy *phy = &adapter->phy; + struct phy_device *phydev = NULL; struct device_node *phynode; - struct phy_device *phydev; struct net_device *netdev; int ret = -EIO;