| Message ID | 20201107172152.828-15-ap420073@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: avoid to remove module when its debugfs is being used | expand |
| Context | Check | Description |
|---|---|---|
| jkicinski/cover_letter | success | Link |
| jkicinski/fixes_present | success | Link |
| jkicinski/patch_count | fail | Series longer than 15 patches |
| jkicinski/tree_selection | success | Clearly marked for net |
| jkicinski/subject_prefix | success | Link |
| jkicinski/source_inline | success | Was 0 now: 0 |
| jkicinski/verify_signedoff | success | Link |
| jkicinski/module_param | success | Was 0 now: 0 |
| jkicinski/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/verify_fixes | success | Link |
| jkicinski/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 14 lines checked |
| jkicinski/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/header_inline | success | Link |
| jkicinski/stable | success | Stable not CCed |
diff --git a/drivers/net/wireless/ath/wcn36xx/debug.c b/drivers/net/wireless/ath/wcn36xx/debug.c index 389b5e7129a6..4b78be5c67e8 100644 --- a/drivers/net/wireless/ath/wcn36xx/debug.c +++ b/drivers/net/wireless/ath/wcn36xx/debug.c @@ -93,6 +93,7 @@ static const struct file_operations fops_wcn36xx_bmps = { .open = simple_open, .read = read_file_bool_bmps, .write = write_file_bool_bmps, + .owner = THIS_MODULE, }; static ssize_t write_file_dump(struct file *file, @@ -134,6 +135,7 @@ static ssize_t write_file_dump(struct file *file, static const struct file_operations fops_wcn36xx_dump = { .open = simple_open, .write = write_file_dump, + .owner = THIS_MODULE, }; #define ADD_FILE(name, mode, fop, priv_data) \
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware") Signed-off-by: Taehee Yoo <ap420073@gmail.com> --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem drivers/net/wireless/ath/wcn36xx/debug.c | 2 ++ 1 file changed, 2 insertions(+)