| Message ID | 20201103025519.1916-1-shipujin.t@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [V2] net: ethernet: mscc: fix missing brace warning for old compilers | expand |
| Context | Check | Description |
|---|---|---|
| jkicinski/cover_letter | success | Link |
| jkicinski/fixes_present | success | Link |
| jkicinski/patch_count | success | Link |
| jkicinski/tree_selection | success | Guessed tree name to be net-next |
| jkicinski/subject_prefix | warning | Target tree name not specified in the subject |
| jkicinski/source_inline | success | Was 0 now: 0 |
| jkicinski/verify_signedoff | success | Link |
| jkicinski/module_param | success | Was 0 now: 0 |
| jkicinski/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/verify_fixes | success | Link |
| jkicinski/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| jkicinski/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/header_inline | success | Link |
| jkicinski/stable | success | Stable not CCed |
On Tue, 3 Nov 2020 10:55:19 +0800 Pujin Shi wrote: > For older versions of gcc, the array = {0}; will cause warnings: Please include the version of gcc which generates this warning here. > drivers/net/ethernet/mscc/ocelot_vcap.c: In function 'is1_entry_set': > drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: missing braces around initializer [-Wmissing-braces] > struct ocelot_vcap_u16 etype = {0}; > ^ > drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: (near initialization for 'etype.value') [-Wmissing-braces] > > 1 warnings generated > > Fixes: 75944fda1dfe ("net: mscc: ocelot: offload ingress skbedit and vlan actions to VCAP IS1") > Signed-off-by: Pujin Shi <shipujin.t@gmail.com> > --- > drivers/net/ethernet/mscc/ocelot_vcap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mscc/ocelot_vcap.c b/drivers/net/ethernet/mscc/ocelot_vcap.c > index d8c778ee6f1b..b5167570521c 100644 > --- a/drivers/net/ethernet/mscc/ocelot_vcap.c > +++ b/drivers/net/ethernet/mscc/ocelot_vcap.c > @@ -752,7 +752,7 @@ static void is1_entry_set(struct ocelot *ocelot, int ix, > dport); > } else { > /* IPv4 "other" frame */ > - struct ocelot_vcap_u16 etype = {0}; > + struct ocelot_vcap_u16 etype = {{0}}; I believe Vladimir asked to use a memset instead; struct ocelot_vcap_u16 etype; memset(&etype, 0, sizeof(etype)); > /* Overloaded field */ > etype.value[0] = proto.value[0];
On Tue, Nov 03, 2020 at 11:05:09AM -0800, Jakub Kicinski wrote: > I believe Vladimir asked to use a memset instead; > > struct ocelot_vcap_u16 etype; > > memset(&etype, 0, sizeof(etype)); Thanks, Jakub.
diff --git a/drivers/net/ethernet/mscc/ocelot_vcap.c b/drivers/net/ethernet/mscc/ocelot_vcap.c index d8c778ee6f1b..b5167570521c 100644 --- a/drivers/net/ethernet/mscc/ocelot_vcap.c +++ b/drivers/net/ethernet/mscc/ocelot_vcap.c @@ -752,7 +752,7 @@ static void is1_entry_set(struct ocelot *ocelot, int ix, dport); } else { /* IPv4 "other" frame */ - struct ocelot_vcap_u16 etype = {0}; + struct ocelot_vcap_u16 etype = {{0}}; /* Overloaded field */ etype.value[0] = proto.value[0];
For older versions of gcc, the array = {0}; will cause warnings: drivers/net/ethernet/mscc/ocelot_vcap.c: In function 'is1_entry_set': drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: missing braces around initializer [-Wmissing-braces] struct ocelot_vcap_u16 etype = {0}; ^ drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: (near initialization for 'etype.value') [-Wmissing-braces] 1 warnings generated Fixes: 75944fda1dfe ("net: mscc: ocelot: offload ingress skbedit and vlan actions to VCAP IS1") Signed-off-by: Pujin Shi <shipujin.t@gmail.com> --- drivers/net/ethernet/mscc/ocelot_vcap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)