| Message ID | 20201031102916.667619-2-vladimir.oltean@nxp.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | VLAN improvements for Ocelot switch | expand |
| Context | Check | Description |
|---|---|---|
| jkicinski/cover_letter | success | Link |
| jkicinski/fixes_present | success | Link |
| jkicinski/patch_count | success | Link |
| jkicinski/tree_selection | success | Clearly marked for net-next |
| jkicinski/subject_prefix | success | Link |
| jkicinski/source_inline | success | Was 0 now: 0 |
| jkicinski/verify_signedoff | success | Link |
| jkicinski/module_param | success | Was 0 now: 0 |
| jkicinski/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/verify_fixes | success | Link |
| jkicinski/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 106 lines checked |
| jkicinski/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/header_inline | success | Link |
| jkicinski/stable | success | Stable not CCed |
Hello, On 31/10/2020 12:29:10+0200, Vladimir Oltean wrote: > Currently, mscc_ocelot ports configure pvid=0 in standalone mode, and > inherit the pvid from the bridge when one is present. > > When the bridge has vlan_filtering=0, the software semantics are that > packets should be received regardless of whether there's a pvid > configured on the ingress port or not. However, ocelot does not observe > those semantics today. > > Moreover, changing the PVID is also a problem with vlan_filtering=0. > We are privately remapping the VID of FDB, MDB entries to the port's > PVID when those are VLAN-unaware (i.e. when the VID of these entries > comes to us as 0). But we have no logic of adjusting that remapping when > the user changes the pvid and vlan_filtering is 0. So stale entries > would be left behind, and untagged traffic will stop matching on them. > > And even if we were to solve that, there's an even bigger problem. If > swp0 has pvid 1, and swp1 has pvid 2, and both are under a vlan_filtering=0 > bridge, they should be able to forward traffic between one another. > However, with ocelot they wouldn't do that. > > The simplest way of fixing this is to never configure the pvid based on > what the bridge is asking for, when vlan_filtering is 0. Only if there > was a VLAN that the bridge couldn't mangle, that we could use as pvid.... > So, turns out, there's 0 just for that. And for a reason: IEEE > 802.1Q-2018, page 247, Table 9-2-Reserved VID values says: > > The null VID. Indicates that the tag header contains only > priority information; no VID is present in the frame. > This VID value shall not be configured as a PVID or a member > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > of a VID Set, or configured in any FDB entry, or used in any > Management operation. > > So, aren't we doing exactly what 802.1Q says not to? Well, in a way, but > what we're doing here is just driver-level bookkeeping, all for the > better. The fact that we're using a pvid of 0 is not observable behavior > from the outside world: the network stack does not see the classified > VLAN that the switch uses, in vlan_filtering=0 mode. And we're also more > consistent with the standalone mode now. > IIRC, we are using pvid 1 because else bridging breaks when CONFIG_VLAN_8021Q is not enabled. Did you test that configuration?
On Mon, Nov 02, 2020 at 09:47:20AM +0100, Alexandre Belloni wrote: > IIRC, we are using pvid 1 because else bridging breaks when > CONFIG_VLAN_8021Q is not enabled. Did you test that configuration? Pertinent question. I hadn't tested that, but I did now. [root@LS1028ARDB ~] # zcat /proc/config.gz | grep 8021Q # CONFIG_VLAN_8021Q is not set [root@LS1028ARDB ~] # ip addr flush swp0 [root@LS1028ARDB ~] # ip addr add 192.168.1.2/24 dev swp0 [root@LS1028ARDB ~] # ping 192.168.1.1 PING 192.168.1.1 (192.168.1.1): 56 data bytes 64 bytes from 192.168.1.1: seq=0 ttl=64 time=0.717 ms 64 bytes from 192.168.1.1: seq=1 ttl=64 time=0.442 ms ^C --- 192.168.1.1 ping statistics --- 2 packets transmitted, 2 packets received, 0% packet loss round-trip min/avg/max = 0.442/0.579/0.717 ms [root@LS1028ARDB ~] # ip addr flush swp0 [root@LS1028ARDB ~] # ip link add br0 type bridge [root@LS1028ARDB ~] # ip link set swp0 master br0 [ 409.576303] br0: port 1(swp0) entered blocking state [ 409.581380] br0: port 1(swp0) entered disabled state [ 409.586738] device swp0 entered promiscuous mode [ 409.591866] br0: port 1(swp0) entered blocking state [ 409.596852] br0: port 1(swp0) entered forwarding state [root@LS1028ARDB ~] # ip addr add 192.168.1.2/24 dev br0 [root@LS1028ARDB ~] # ping 192.168.1.1 PING 192.168.1.1 (192.168.1.1): 56 data bytes 64 bytes from 192.168.1.1: seq=0 ttl=64 time=0.768 ms 64 bytes from 192.168.1.1: seq=1 ttl=64 time=0.657 ms 64 bytes from 192.168.1.1: seq=2 ttl=64 time=0.509 ms 64 bytes from 192.168.1.1: seq=3 ttl=64 time=0.513 ms 64 bytes from 192.168.1.1: seq=4 ttl=64 time=0.496 ms ^C --- 192.168.1.1 ping statistics --- 5 packets transmitted, 5 packets received, 0% packet loss round-trip min/avg/max = 0.496/0.588/0.768 ms [root@LS1028ARDB ~] # ip link del br0 [ 135.526825] device swp0 left promiscuous mode [ 135.531729] br0: port 1(swp0) entered disabled state [root@LS1028ARDB ~] # ip addr add 192.168.1.2/24 dev swp0 [root@LS1028ARDB ~] # ping 192.168.1.1 PING 192.168.1.1 (192.168.1.1): 56 data bytes 64 bytes from 192.168.1.1: seq=0 ttl=64 time=0.783 ms 64 bytes from 192.168.1.1: seq=1 ttl=64 time=0.289 ms 64 bytes from 192.168.1.1: seq=2 ttl=64 time=0.412 ms 64 bytes from 192.168.1.1: seq=3 ttl=64 time=0.399 ms 64 bytes from 192.168.1.1: seq=4 ttl=64 time=0.396 ms 64 bytes from 192.168.1.1: seq=5 ttl=64 time=0.390 ms ^C --- 192.168.1.1 ping statistics --- 6 packets transmitted, 6 packets received, 0% packet loss round-trip min/avg/max = 0.289/0.444/0.783 ms There's no logical reason why it wouldn't work. Thanks to your code which ensures VLAN 0 is in the VLAN table. Nobody is removing VLAN 0 right now. /* Because VLAN filtering is enabled, we need VID 0 to get untagged * traffic. It is added automatically if 8021q module is loaded, but * we can't rely on it since module may be not loaded. */ ocelot->vlan_mask[0] = GENMASK(ocelot->num_phys_ports - 1, 0); ocelot_vlant_set_mask(ocelot, 0, ocelot->vlan_mask[0]); I cannot test the mscc_ocelot driver, I am only testing felix DSA, and for that reason I can't even go very far down the history. Remember that when CONFIG_VLAN_8021Q is disabled, CONFIG_BRIDGE_VLAN_FILTERING also needs to be disabled. So logically speaking, nobody calls any VLAN function when CONFIG_VLAN_8021Q is disabled. The standalone configuration should work in this mode too, shouldn't it? I am not sure if there's any relevant difference for mscc_ocelot.
diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c index 323dbd30661a..bc5b15d7bce7 100644 --- a/drivers/net/ethernet/mscc/ocelot.c +++ b/drivers/net/ethernet/mscc/ocelot.c @@ -199,6 +199,22 @@ static int ocelot_port_set_native_vlan(struct ocelot *ocelot, int port, return 0; } +/* Default vlan to clasify for untagged frames (may be zero) */ +static void ocelot_port_set_pvid(struct ocelot *ocelot, int port, u16 pvid) +{ + struct ocelot_port *ocelot_port = ocelot->ports[port]; + + ocelot_port->pvid = pvid; + + if (!ocelot_port->vlan_aware) + pvid = 0; + + ocelot_rmw_gix(ocelot, + ANA_PORT_VLAN_CFG_VLAN_VID(pvid), + ANA_PORT_VLAN_CFG_VLAN_VID_M, + ANA_PORT_VLAN_CFG, port); +} + int ocelot_port_vlan_filtering(struct ocelot *ocelot, int port, bool vlan_aware, struct switchdev_trans *trans) { @@ -233,25 +249,13 @@ int ocelot_port_vlan_filtering(struct ocelot *ocelot, int port, ANA_PORT_VLAN_CFG_VLAN_POP_CNT_M, ANA_PORT_VLAN_CFG, port); + ocelot_port_set_pvid(ocelot, port, ocelot_port->pvid); ocelot_port_set_native_vlan(ocelot, port, ocelot_port->vid); return 0; } EXPORT_SYMBOL(ocelot_port_vlan_filtering); -/* Default vlan to clasify for untagged frames (may be zero) */ -static void ocelot_port_set_pvid(struct ocelot *ocelot, int port, u16 pvid) -{ - struct ocelot_port *ocelot_port = ocelot->ports[port]; - - ocelot_rmw_gix(ocelot, - ANA_PORT_VLAN_CFG_VLAN_VID(pvid), - ANA_PORT_VLAN_CFG_VLAN_VID_M, - ANA_PORT_VLAN_CFG, port); - - ocelot_port->pvid = pvid; -} - int ocelot_vlan_add(struct ocelot *ocelot, int port, u16 vid, bool pvid, bool untagged) { @@ -542,26 +546,11 @@ EXPORT_SYMBOL(ocelot_get_txtstamp); int ocelot_fdb_add(struct ocelot *ocelot, int port, const unsigned char *addr, u16 vid) { - struct ocelot_port *ocelot_port = ocelot->ports[port]; int pgid = port; if (port == ocelot->npi) pgid = PGID_CPU; - if (!vid) { - if (!ocelot_port->vlan_aware) - /* If the bridge is not VLAN aware and no VID was - * provided, set it to pvid to ensure the MAC entry - * matches incoming untagged packets - */ - vid = ocelot_port->pvid; - else - /* If the bridge is VLAN aware a VID must be provided as - * otherwise the learnt entry wouldn't match any frame. - */ - return -EINVAL; - } - return ocelot_mact_learn(ocelot, pgid, addr, vid, ENTRYTYPE_LOCKED); } EXPORT_SYMBOL(ocelot_fdb_add); @@ -1048,7 +1037,6 @@ static void ocelot_encode_ports_to_mdb(unsigned char *addr, int ocelot_port_mdb_add(struct ocelot *ocelot, int port, const struct switchdev_obj_port_mdb *mdb) { - struct ocelot_port *ocelot_port = ocelot->ports[port]; unsigned char addr[ETH_ALEN]; struct ocelot_multicast *mc; struct ocelot_pgid *pgid; @@ -1057,9 +1045,6 @@ int ocelot_port_mdb_add(struct ocelot *ocelot, int port, if (port == ocelot->npi) port = ocelot->num_phys_ports; - if (!vid) - vid = ocelot_port->pvid; - mc = ocelot_multicast_get(ocelot, mdb->addr, vid); if (!mc) { /* New entry */ @@ -1108,7 +1093,6 @@ EXPORT_SYMBOL(ocelot_port_mdb_add); int ocelot_port_mdb_del(struct ocelot *ocelot, int port, const struct switchdev_obj_port_mdb *mdb) { - struct ocelot_port *ocelot_port = ocelot->ports[port]; unsigned char addr[ETH_ALEN]; struct ocelot_multicast *mc; struct ocelot_pgid *pgid; @@ -1117,9 +1101,6 @@ int ocelot_port_mdb_del(struct ocelot *ocelot, int port, if (port == ocelot->npi) port = ocelot->num_phys_ports; - if (!vid) - vid = ocelot_port->pvid; - mc = ocelot_multicast_get(ocelot, mdb->addr, vid); if (!mc) return -ENOENT;
Currently, mscc_ocelot ports configure pvid=0 in standalone mode, and inherit the pvid from the bridge when one is present. When the bridge has vlan_filtering=0, the software semantics are that packets should be received regardless of whether there's a pvid configured on the ingress port or not. However, ocelot does not observe those semantics today. Moreover, changing the PVID is also a problem with vlan_filtering=0. We are privately remapping the VID of FDB, MDB entries to the port's PVID when those are VLAN-unaware (i.e. when the VID of these entries comes to us as 0). But we have no logic of adjusting that remapping when the user changes the pvid and vlan_filtering is 0. So stale entries would be left behind, and untagged traffic will stop matching on them. And even if we were to solve that, there's an even bigger problem. If swp0 has pvid 1, and swp1 has pvid 2, and both are under a vlan_filtering=0 bridge, they should be able to forward traffic between one another. However, with ocelot they wouldn't do that. The simplest way of fixing this is to never configure the pvid based on what the bridge is asking for, when vlan_filtering is 0. Only if there was a VLAN that the bridge couldn't mangle, that we could use as pvid.... So, turns out, there's 0 just for that. And for a reason: IEEE 802.1Q-2018, page 247, Table 9-2-Reserved VID values says: The null VID. Indicates that the tag header contains only priority information; no VID is present in the frame. This VID value shall not be configured as a PVID or a member ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ of a VID Set, or configured in any FDB entry, or used in any Management operation. So, aren't we doing exactly what 802.1Q says not to? Well, in a way, but what we're doing here is just driver-level bookkeeping, all for the better. The fact that we're using a pvid of 0 is not observable behavior from the outside world: the network stack does not see the classified VLAN that the switch uses, in vlan_filtering=0 mode. And we're also more consistent with the standalone mode now. And now that we use the pvid of 0 in this mode, there's another advantage: we don't need to perform any VID remapping for FDB and MDB entries either, we can just use the VID of 0 that the bridge is passing to us. The only gotcha is that every time we change the vlan_filtering setting, we need to reapply the pvid (either to 0, or to the value from the bridge). A small side-effect visible in the patch is that ocelot_port_set_pvid needs to be moved above ocelot_port_vlan_filtering, so that it can be called from there without forward-declarations. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- drivers/net/ethernet/mscc/ocelot.c | 53 ++++++++++-------------------- 1 file changed, 17 insertions(+), 36 deletions(-)