From patchwork Fri Sep 25 13:16:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Frederick X-Patchwork-Id: 1371292 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=skynet.be Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4ByXWn6G6Fz9sSn for ; Fri, 25 Sep 2020 23:17:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728926AbgIYNRW (ORCPT ); Fri, 25 Sep 2020 09:17:22 -0400 Received: from mailrelay112.isp.belgacom.be ([195.238.20.139]:53084 "EHLO mailrelay112.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728171AbgIYNRW (ORCPT ); Fri, 25 Sep 2020 09:17:22 -0400 IronPort-SDR: USMfB1R/kPsaPPtMKtrw6y4KpdXbRn9yttPoAEjW98AUBN5H/7t9qQLV9gnatcQMyQEfL8HqRI JisXZ7sgVHzp6zaIAm8o1ASnzPywfSEnnIxb/5pFqcz/hbaoeRbKBZ1Y9cp0Ve2b8LP0jG0P2P k1EgUT0YEkp0qZBaK/uP7g6HKcwM68ApyNsUpFCU9/k8E5Xw6PT+okmfR4JvW1PTc9ZPC+Px0g vT4pQ8TQFTiG26FdkC8s8mxdu1MFUk8TXHwR3gWY5P8X/GNoeT5iS0mBFiT7C51I5qDx+6axi4 GK8= X-Belgacom-Dynamic: yes IronPort-PHdr: 9a23:qocG0xK5Wts6YGvlj9mcpTZWNBhigK39O0sv0rFitYgXKvv4rarrMEGX3/hxlliBBdydt6sbzbCO+P2xEUU7or+5+EgYd5JNUxJXwe43pCcHRPC/NEvgMfTxZDY7FskRHHVs/nW8LFQHUJ2mPw6arXK99yMdFQviPgRpOOv1BpTSj8Oq3Oyu5pHfeQpFiCe/bL9oMhm6sQrdu8kSjIB/Nqs/1xzFr2dSde9L321oP1WTnxj95se04pFu9jlbtuwi+cBdT6j0Zrw0QrNEAjsoNWA1/9DrugLYTQST/HscU34ZnQRODgPY8Rz1RJbxsi/9tupgxCmXOND9QL4oVTi+6apgVRnlgzoFOTEk6mHaksx+grxGrhyvpBJxxIHbbo6OOfZifa7QZ88WSHBdUspNUSFKH4Oyb5EID+oEJetWr5PyqEAPrRSkAwmnGePhyiVWiXDrw6I6yeUhHh3F3Ac9GN8Ovm7bo877NKoJSuC1z6nJzTPdYPNKwzvy85bHfwknrPqRUr1+bdDfxlMzFwPZkFqQs4rlMiub2OkOt2WV7+ttWOKxh2Mpqw98vySjytowhoTIiYwbxU3J+CtnzYsoJdC1SlB2b9G4HJVeuC+XM4t4TMM8T2xsvisx174IuYajcSUO1Zgr3QPTZv+Zf4SS/x7uVeacLS1liH9kfr+0mgy8/lK6yuLmU8m5yFNKri1YndbSrn0NzBnT6tSfSvt640ehxS6D1wDN5eFAJkA5ja7bK5k9zbEqkpoTsUPDHjTqmEnsiK+WcVkr9fKs6+v6ZbXmo4WTN45yig3mM6QunNKwAfggPwUKQmSX4/mw2b798UHjXblHj/07nrPEvJ3bPcgbo7S2Aw5R0oYt8Ra/CDKm3cwWnXYdN11FdgmKj5PqO1DOJvD3E+u/j063nzh13/zGJKHuAo3RLnjfl7fsZaty5FRCyAUtyNBS/I9bBasfIP3tX0/xsNvYDhElMwCuxeboFsl93JsEWW2TGq+ZLL/SsViQ6+IsPumDf5UatS3+K/c7/f7ui2E2mVsHcamux5sXZ2iyHu56LEWBfXrsntABHH8Pvgo9Uezlk0ONXiJNaHaxRK88/Sw7CJm4AovZWo+sgaSL3D2nEZ1OemBGFleMHG/ud4qaR/cDdTydItF6nzwaWriuVZUh2QuttADk0bpnKPTb+ikCuZLkzth16PXZlQsu+jxsE8Sdz2aNQnlwnmMJQT82wa9+rVV+ylidy6h4heJXFdhI6vNXXQc1K4Tcw/Z5C9/sQALBeMmGSFK8TtWhGzExQco7w8USbEZlB9WikhfD0jKkA7APjLOLCoc58rnf33nxIcZy1WrG2LM6gFY4EYNzMjiqj7By8iDfDpDElkGembrsc6kAmGbO6W2K5WmDpkdVVEh3S6qWc2oYYx74pN7470WKYaWjBbk9MwBCgZqMI6FEQsbqnFNLWLHpNYKNMCqKh26sCEPQlfu3Z43wdjBF0Q== X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2ASEgDD7G1f/xCltltfHAEBATwBAQQEAQECAQEHAQEcgUqBHCACAQGCLV+NPpJiiliHLAsBAQEBAQEBAQE1AQIEAQGES4IxJTgTAgMBAQEDAgUBAQYBAQEBAQEFBAGGD0WCNyKDUgEjI4E/EoMmglgpuHKEEIURgUKBNgIBAQEBiCuFGoFBP4ERg06EBIYwBLc9gnGDE4RpkkwPIoJ7nhUtkluiGIF6TSAYgyRQGQ2caEIwNwIGCgEBAwlXAT0Bi1mCRgEB X-IPAS-Result: A2ASEgDD7G1f/xCltltfHAEBATwBAQQEAQECAQEHAQEcgUqBHCACAQGCLV+NPpJiiliHLAsBAQEBAQEBAQE1AQIEAQGES4IxJTgTAgMBAQEDAgUBAQYBAQEBAQEFBAGGD0WCNyKDUgEjI4E/EoMmglgpuHKEEIURgUKBNgIBAQEBiCuFGoFBP4ERg06EBIYwBLc9gnGDE4RpkkwPIoJ7nhUtkluiGIF6TSAYgyRQGQ2caEIwNwIGCgEBAwlXAT0Bi1mCRgEB Received: from 16.165-182-91.adsl-dyn.isp.belgacom.be (HELO localhost.localdomain) ([91.182.165.16]) by relay.skynet.be with ESMTP; 25 Sep 2020 15:17:20 +0200 From: Fabian Frederick To: davem@davemloft.net, kuba@kernel.org Cc: mkubecek@suse.cz, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Fabian Frederick Subject: [PATCH V2 4/5 net-next] vxlan: check rtnl_configure_link return code correctly Date: Fri, 25 Sep 2020 15:16:59 +0200 Message-Id: <20200925131659.56615-1-fabf@skynet.be> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org rtnl_configure_link is always checked if < 0 for error code. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 14f903d09c010..1e9ab1002281c 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -3890,7 +3890,7 @@ static int __vxlan_dev_create(struct net *net, struct net_device *dev, } err = rtnl_configure_link(dev, NULL); - if (err) + if (err < 0) goto unlink; if (f) {