Message ID | 20200918143311.GD909725@mwanda |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | [net] sfc: Fix error code in probe | expand |
On 18/09/2020 15:33, Dan Carpenter wrote: > This failure path should return a negative error code but it currently > returns success. > > Fixes: 51b35a454efd ("sfc: skeleton EF100 PF driver") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Edward Cree <ecree@solarflare.com> Thanks for catching this.
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Fri, 18 Sep 2020 17:33:11 +0300 > This failure path should return a negative error code but it currently > returns success. > > Fixes: 51b35a454efd ("sfc: skeleton EF100 PF driver") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied, thanks.
diff --git a/drivers/net/ethernet/sfc/ef100.c b/drivers/net/ethernet/sfc/ef100.c index c54b7f8243f3..ffdb36715a49 100644 --- a/drivers/net/ethernet/sfc/ef100.c +++ b/drivers/net/ethernet/sfc/ef100.c @@ -490,6 +490,7 @@ static int ef100_pci_probe(struct pci_dev *pci_dev, if (fcw.offset > pci_resource_len(efx->pci_dev, fcw.bar) - ESE_GZ_FCW_LEN) { netif_err(efx, probe, efx->net_dev, "Func control window overruns BAR\n"); + rc = -EIO; goto fail; }
This failure path should return a negative error code but it currently returns success. Fixes: 51b35a454efd ("sfc: skeleton EF100 PF driver") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/ethernet/sfc/ef100.c | 1 + 1 file changed, 1 insertion(+)