diff mbox series

[V1,net-next,5/8] net: ena: Remove redundant print of placement policy

Message ID 20200913082056.3610-6-shayagr@amazon.com
State Changes Requested
Delegated to: David Miller
Headers show
Series Update license and polish ENA driver code | expand

Commit Message

Shay Agroskin Sept. 13, 2020, 8:20 a.m. UTC 
The placement policy is printed in the process of queue creation in
ena_up(). No need to print it in ena_probe().

Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: Shay Agroskin <shayagr@amazon.com>
---
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

Comments

Shay Agroskin Sept. 13, 2020, 11:03 a.m. UTC | #1 
Shay Agroskin <shayagr@amazon.com> writes:

> The placement policy is printed in the process of queue creation 
> in
> ena_up(). No need to print it in ena_probe().
>
> Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
> Signed-off-by: Shay Agroskin <shayagr@amazon.com>
> ---
>  drivers/net/ethernet/amazon/ena/ena_netdev.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c 
> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index cab83a9de651..97e701222226 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -4156,7 +4156,6 @@ static int ena_probe(struct pci_dev *pdev, 
> const struct pci_device_id *ent)
>  	struct net_device *netdev;
>  	static int adapters_found;
>  	u32 max_num_io_queues;
> -	char *queue_type_str;
>  	bool wd_state;
>  	int bars, rc;
>  
> @@ -4334,15 +4333,10 @@ static int ena_probe(struct pci_dev 
> *pdev, const struct pci_device_id *ent)
>  	timer_setup(&adapter->timer_service, ena_timer_service, 
>  0);
>  	mod_timer(&adapter->timer_service, round_jiffies(jiffies + 
>  HZ));
>  
> -	if (ena_dev->tx_mem_queue_type == 
> ENA_ADMIN_PLACEMENT_POLICY_HOST)
> -		queue_type_str = "Regular";
> -	else
> -		queue_type_str = "Low Latency";
> -
>  	dev_info(&pdev->dev,
> -		 "%s found at mem %lx, mac addr %pM, Placement 
> policy: %s\n",
> +		 "%s found at mem %lx, mac addr %pM\n",
>  		 DEVICE_NAME, (long)pci_resource_start(pdev, 0),
> -		 netdev->dev_addr, queue_type_str);
> +		 netdev->dev_addr);
>  
>  	set_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags);

Hi, I got this patchset messed up a little. These patches are part 
of the 'Update license and polish ENA driver code' patchset 
(Message-id: <20200913081640.19560-1-shayagr@amazon.com>)
Sorry for the clutter. Please let me know it you prefer that I 
re-send this patchset as a single thread
diff mbox series

Patch

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index cab83a9de651..97e701222226 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -4156,7 +4156,6 @@  static int ena_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	struct net_device *netdev;
 	static int adapters_found;
 	u32 max_num_io_queues;
-	char *queue_type_str;
 	bool wd_state;
 	int bars, rc;
 
@@ -4334,15 +4333,10 @@  static int ena_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	timer_setup(&adapter->timer_service, ena_timer_service, 0);
 	mod_timer(&adapter->timer_service, round_jiffies(jiffies + HZ));
 
-	if (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_HOST)
-		queue_type_str = "Regular";
-	else
-		queue_type_str = "Low Latency";
-
 	dev_info(&pdev->dev,
-		 "%s found at mem %lx, mac addr %pM, Placement policy: %s\n",
+		 "%s found at mem %lx, mac addr %pM\n",
 		 DEVICE_NAME, (long)pci_resource_start(pdev, 0),
-		 netdev->dev_addr, queue_type_str);
+		 netdev->dev_addr);
 
 	set_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags);