| Message ID | 20200904025103.39405-1-jingxiangfeng@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | atm: eni: fix the missed pci_disable_device() for eni_init_one() | expand |
On Fri, 4 Sep 2020 10:51:03 +0800 Jing Xiangfeng wrote: > eni_init_one() misses to call pci_disable_device() in an error path. > Jump to err_disable to fix it. > > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> Please make sure you add appropriate fixes tags, here: Fixes: ede58ef28e10 ("atm: remove deprecated use of pci api") Thank you. Applied.
diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c index 39be444534d0..316a9947541f 100644 --- a/drivers/atm/eni.c +++ b/drivers/atm/eni.c @@ -2224,7 +2224,7 @@ static int eni_init_one(struct pci_dev *pci_dev, rc = dma_set_mask_and_coherent(&pci_dev->dev, DMA_BIT_MASK(32)); if (rc < 0) - goto out; + goto err_disable; rc = -ENOMEM; eni_dev = kmalloc(sizeof(struct eni_dev), GFP_KERNEL);
eni_init_one() misses to call pci_disable_device() in an error path. Jump to err_disable to fix it. Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> --- drivers/atm/eni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)